This repository was archived by the owner on Nov 17, 2022. It is now read-only.
Update gitian-building.md #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK e0f5e6c |
maflcko
pushed a commit
that referenced
this pull request
Apr 22, 2019
e0f5e6c Update gitian-building.md (KanoczTomas) Pull request description: Fixed usage of VERSION variable (it was partly static in the docs and not exported) and unified the signer's name to variable NAME (it was sometimes SIGNER, sometimes NAME). ACKs for commit e0f5e6: hebasto: utACK e0f5e6c Tree-SHA512: cad64870bcd0c589a5c6fa54bf9871630ef1b93c3795b740506e34ed084acd3a420a5bfd288345ffc5eaa509225375b231b1176019ed0eab2c7d90a3d58e26ca
maflcko
reviewed
Apr 25, 2019
| git clone git@github.com:bitcoin-core/gitian.sigs.git | ||
| git remote add satoshi git@github.com:satoshi/gitian.sigs.git | ||
| git remote add $NAME git@github.com:$NAME/gitian.sigs.git |
There was a problem hiding this comment.
The second $NAME should be where the repo was forked to? Might want to clarify that in a follow-up?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed usage of VERSION variable (it was partly static in the docs and not exported) and unified the signer's name to variable NAME (it was sometimes SIGNER, sometimes NAME).