Only show Onboarding if settings file is missing #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
reviewed
Feb 5, 2023
Closed
johnny9
force-pushed
the
need-onboarding
branch
from
46b1904 to
27c38a9
Compare
hebasto
changed the title
|
FWIW, the relevant Qt widget GUI logic is implemented in Line 203 in d1c51ac |
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
… is missing 81b9ce0 qml: only show Onboarding if settings/conf file is missing (johnny9) Pull request description: Commit adds a context property that is used to determine if Onboarding flow is needed. If the user supplies a data directory or their settings.json file is missing, the property "needOnboarding" will be set to true. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>) ACKs for top commit: jarolrod: ACK 81b9ce0 Tree-SHA512: 80cd9e2cf07a4e107918353e0f98880fdfacc78e7348cc6ab1006b58858f0ca18aafc9315344e991da073ee42a9b1459f4d9c60da1b646516aa6370ef735cf18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit adds a context property that is used to determine if Onboarding flow is needed. If the user supplies a data directory or their settings.json file is missing, the property "needOnboarding" will be set to true.