Skip to content

Fix NetworkIndicator font size and padding #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jarolrod
Copy link
Member

Addresses this review feedback, and gets us to fit with the design file. Overlooked in #251

Master

testnet signet regtest
testnet-master signet-master regtest

PR

testnet signet regtest
testnet-pr signet-pr regtest-pr

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e621826

@hebasto hebasto merged commit 294a978 into bitcoin-core:main Feb 13, 2023
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
…dding

d94376c qml: fix NetworkIndicator font size and padding (jarolrod)

Pull request description:

  Addresses [this](bitcoin-core/gui-qml#251 (comment)) review feedback, and gets us to fit with the [design file](https://www.figma.com/file/ek8w3n3upbluw5UL2lGhRx/Bitcoin-Core-App-Design?node-id=6010%3A67918&t=N1q0V96d7QISBeRs-4). Overlooked in bitcoin-core/gui-qml#251

  ### Master

  | testnet | signet | regtest |
  | ------- | ------ | ------- |
  | <img width="752" alt="testnet-master" src="https://user-images.githubusercontent.com/23396902/218172893-9ad1b653-1a25-4fe6-9429-e422b1f799ca.png"> | <img width="752" alt="signet-master" src="https://user-images.githubusercontent.com/23396902/218172938-ac394c8b-608e-444c-89c2-804e953a7b9e.png"> | <img width="752" alt="regtest" src="https://user-images.githubusercontent.com/23396902/218172980-a23d0329-ae53-4719-8d25-f20f8d48cbac.png"> |

  ### PR

  | testnet | signet | regtest |
  | ------- | ------ | ------- |
  | <img width="752" alt="testnet-pr" src="https://user-images.githubusercontent.com/23396902/218173081-e610be32-c78c-46c9-a741-1e454bbe7a9f.png"> | <img width="752" alt="signet-pr" src="https://user-images.githubusercontent.com/23396902/218173130-483afeb1-bb25-4d53-a9f2-3e2da755ae39.png"> | <img width="752" alt="regtest-pr" src="https://user-images.githubusercontent.com/23396902/218173172-26449e22-5f32-4ad7-8289-5aa5e8d98428.png"> |

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>)

ACKs for top commit:
  johnny9:
    ACK d94376c

Tree-SHA512: 3094cd1e9fb7f9c0e6e276a80cfa190e9ae80991d6029fdbe793485dcaea76a14e4c5a9734a840b374f04653557d7ca33dd4074020565e81fcef7735abeb080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants