Ignore clang's self-assignment check #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
reviewed
Jun 11, 2024
As-documented in the code, this is already safe so ignore the false-positive.
theuni
force-pushed
the
ignore-self-assign
branch
from
71acc5a to
7045a90
Compare
|
ACK 7045a90 |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 13, 2024
688561cba8 Merge bitcoin-core/leveldb-subtree#41: Ignore clang's self-assignment check 7045a90ed7 Ignore clang's self-assignment check git-subtree-dir: src/leveldb git-subtree-split: 688561cba8746482893f835c4829e4eb4a5b7615
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jun 14, 2024
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in #30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Jul 26, 2024
688561cba8 Merge bitcoin-core/leveldb-subtree#41: Ignore clang's self-assignment check 7045a90ed7 Ignore clang's self-assignment check git-subtree-dir: src/leveldb git-subtree-split: 688561cba8746482893f835c4829e4eb4a5b7615
vmta
added a commit
to umkoin/umkoin
that referenced
this pull request
Sep 12, 2024
688561cba Merge bitcoin-core/leveldb-subtree#41: Ignore clang's self-assignment check 7045a90ed Ignore clang's self-assignment check e2f10b4e4 Merge bitcoin-core/leveldb-subtree#34: win32: fix -Wmissing-field-initializers warnings 12c52b392 win32: fix -Wmissing-field-initializers warnings 22f1e4a02 Merge bitcoin-core/leveldb-subtree#32: fix macro HAVE_O_CLOEXEC when O_CLOEXEC not found 1eeb1cb87 fix macro HAVE_O_CLOEXEC when O_CLOEXEC not found git-subtree-dir: src/leveldb git-subtree-split: 688561cba8746482893f835c4829e4eb4a5b7615
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 25, 2024
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 30, 2024
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 17, 2025
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 19, 2025
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 20, 2025
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 20, 2025
a37778d Squashed 'src/leveldb/' changes from e2f10b4e47..688561cba8 (fanquake) Pull request description: Includes bitcoin-core/leveldb-subtree#41 which is used in bitcoin#30234. ACKs for top commit: theuni: utACK 95812d9 Tree-SHA512: 3d943695a3d33816cf5558b183f5629aa92a500a1544eecedf84952e93c8592a8cf0d554b88281fc0bad3c9e920ebcff1ed8edc12f8e73f36ed5335482beb829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-documented in the code, this is already safe so ignore the false-positive.
Necessary to turn on the option in bitcoin/bitcoin#30234. Passes tests there.