Skip to content

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Jul 13, 2023

This is a follow-up to #131 (comment)

It should have moved the inputs in the first place to avoid duplicating them. There is no value in duplicating them. While .git can de-duplicate the files internally, it still hurts storage when the files are checked out. Also it hurts CPU when the fuzz runner is running the same input twice.

@maflcko
Copy link
Contributor Author

maflcko commented Jul 13, 2023

Done with:

cd ./fuzz_seed_corpus/
for p in ./process_message_* ; do git mv --force ./$p/* ./process_message/ ; done

@fanquake
Copy link
Member

@dergoegge

@maflcko
Copy link
Contributor Author

maflcko commented Jul 14, 2023

(CI can be ignored, obviously)

@maflcko
Copy link
Contributor Author

maflcko commented Jul 28, 2023

Should be trivial to reproduce the scripted diff with the bash oneliner above. Also review should be trivial, no?

@dergoegge
Copy link
Member

Should be trivial to reproduce the scripted diff with the bash oneliner above. Also review should be trivial, no?

Sorry dropped of my radar.

Can't we just delete the individual folders, since we merged the inputs in #131?

@maflcko
Copy link
Contributor Author

maflcko commented Jul 28, 2023

Can't we just delete the individual folders, since we merged the inputs in #131?

Yes, happy to do that. There might be a small benefit in keeping all inputs for now, so that the targets from transform_process_message_target have access to all the same fuzz inputs that were there previously before moving everything into one folder.

But it shouldn't matter, because the next https://github.com/bitcoin-core/qa-assets#pruning-inputs run will delete them anyway. So happy to do either.

@dergoegge
Copy link
Member

ACK ca4413b

@fanquake fanquake merged commit f882b60 into bitcoin-core:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants