Skip to content

Conversation

sipa
Copy link
Contributor

@sipa sipa commented Sep 11, 2023

No description provided.

@maflcko
Copy link
Contributor

maflcko commented Sep 11, 2023

lgtm, if CI is green, except for lint, which is currently failing either way.

@sipa sipa changed the title Add initial corpus for p2p_transport_bidirectional_v2 Add initial corpus for p2p_transport_bidirectional_v2 and _v1v2 Sep 11, 2023
@sipa
Copy link
Contributor Author

sipa commented Sep 11, 2023

Added a commit for p2p_transport_bidirectional_v2 and _v1v2 too.

@maflcko
Copy link
Contributor

maflcko commented Sep 12, 2023

Could rebase for fresh CI? But lgtm either way.

@fanquake fanquake requested a review from dergoegge September 12, 2023 10:59
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Not sure how important the secp coverage is in the context of these targets but bitcoin/bitcoin#27990 might be interesting. I suspect that we'll get some extra inputs from oss-fuzz later on that account for the secp coverage (unless you already made sure secp is instrumented during your runs).

@fanquake fanquake merged commit 99a8366 into bitcoin-core:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants