Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secp covering inputs #168

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

dergoegge
Copy link
Member

With bitcoin/bitcoin#28875 merged, our merge script will now account for secp coverage.

This PR merges the available inputs from oss-fuzz into our corpora to bring in the newly accounted for secp coverage.

@murchandamus
Copy link
Contributor

Cool, sounds good

@maflcko
Copy link
Contributor

maflcko commented Jan 30, 2024

Maybe re-run CI here and on main for the coverage summary?

@dergoegge
Copy link
Member Author

Diff for cov output:

bip324_cipher_roundtrip [-8000-]{+8007+}
bip324_ecdh [-3973-]{+4013+}
descriptor_parse [-16246-]{+16264+}
ellswift_roundtrip [-4492-]{+4523+}
key [-9184-]{+9209+}
mocked_descriptor_parse [-15801-]{+15904+}
scriptpubkeyman [-22188-]{+22447+}
secp256k1_ec_seckey_import_export_der 2815
secp256k1_ecdsa_signature_parse_der_lax [-3843-]{+3855+}
wallet_notifications [-18954-]{+18984+}
Whole diff
addition_overflow 347
addr_info_deserialize [-547-]{+548+}
address_deserialize 708
addrman 6493
addrman_serdeser [-6164-]{+6161+}
asmap 566
asmap_direct 255
autofile 617
banman 5481
base_encode_decode [-7599-]{+7604+}
bech32 371
bip324_cipher_roundtrip [-8000-]{+8007+}
bip324_ecdh [-3973-]{+4013+}
bitdeque 3240
block 3738
block_deserialize 702
block_file_info_deserialize 180
block_filter_deserialize 258
block_header 1249
block_header_and_short_txids_deserialize [-758-]{+759+}
blockfilter [-3514-]{+3522+}
blockheader_deserialize 153
blocklocator_deserialize 191
blockmerkleroot 837
blocktransactions_deserialize [-674-]{+673+}
blocktransactionsrequest_deserialize 200
blockundo_deserialize 1219
bloom_filter [-2060-]{+2063+}
bloomfilter_deserialize 185
buffered_file 508
chacha20_split_crypt 2800
chacha20_split_keystream 2898
chain 1213
checkqueue 214
coincontrol 1137
coins_deserialize [-1101-]{+1104+}
coins_view [-7493-]{+7509+}
coinscache_sim [-1592-]{+1581+}
coinselection [-4704-]{+4746+}
connman [-6131-]{+6128+}
crypto 5449
crypto_aes256 469
crypto_aes256cbc 587
crypto_chacha20 2951
crypto_common 86
crypto_diff_fuzz_chacha20 3450
crypto_fschacha20 [-2782-]{+2783+}
crypto_hkdf_hmac_sha256_l32 941
crypto_poly1305 381
crypto_poly1305_split 444
cuckoocache 275
data_stream_addr_man 4927
decode_tx 1543
descriptor_parse [-16246-]{+16264+}
diskblockindex_deserialize 220
ellswift_roundtrip [-4492-]{+4523+}
eval_script 5089
fee_rate 226
fee_rate_deserialize 119
fees 1379
flat_file_pos_deserialize 173
flatfile 311
float 54
golomb_rice [-2654-]{+2650+}
headers_sync_state [-3329-]{+3325+}
hex [-2287-]{+2292+}
http_request 449
integer 2850
inv_deserialize 130
key [-9184-]{+9209+}
key_io 2075
key_origin_info_deserialize 205
kitchen_sink 380
load_external_block_file 2721
locale 370
merkle_block_deserialize 314
merkleblock 2011
message [-7829-]{+7845+}
messageheader_deserialize 156
mini_miner [-6606-]{+6612+}
mini_miner_selection [-8059-]{+8062+}
miniscript_script 3648
miniscript_smart [-11742-]{+11739+}
miniscript_stable 11882
miniscript_string 3482
minisketch [-1510-]{+1511+}
mocked_descriptor_parse [-15801-]{+15904+}
muhash 2435
multiplication_overflow 150
net 2327
net_permissions 1194
netaddr_deserialize [-588-]{+587+}
netaddress [-4387-]{+4379+}
netbase_dns_lookup 2110
node_eviction 935
out_point_deserialize 128
p2p_transport_bidirectional 1725
p2p_transport_bidirectional_v1v2 [-5699-]{+5702+}
p2p_transport_bidirectional_v2 [-9248-]{+9250+}
p2p_transport_serialization 1403
parse_hd_keypath 408
parse_iso8601 737
parse_numbers 490
parse_script 796
parse_univalue 12164
partial_merkle_tree_deserialize 293
partially_downloaded_block [-5892-]{+5882+}
partially_signed_transaction_deserialize [-6909-]{+6918+}
policy_estimator [-2495-]{+2496+}
policy_estimator_io [-857-]{+856+}
pool_resource 1717
pow 695
pow_transition 354
prefilled_transaction_deserialize [-654-]{+653+}
prevector 867
primitives_transaction 1795
process_message [-17692-]{+18016+}
process_messages [-18994-]{+18990+}
protocol 420
psbt [-17831-]{+17845+}
psbt_input_deserialize [-4970-]{+4976+}
psbt_output_deserialize [-2100-]{+2105+}
pub_key_deserialize 180
random 1459
rbf [-5317-]{+5321+}
rolling_bloom_filter 2328
rpc [-46569-]{+46652+}
script [-6888-]{+6884+}
script_bitcoin_consensus [-7662-]{+7667+}
script_descriptor_cache [-924-]{+925+}
script_deserialize 187
script_flags [-9865-]{+9877+}
script_format [-5225-]{+5223+}
script_interpreter 1922
script_ops 711
script_sigcache [-4365-]{+4412+}
script_sign [-14319-]{+14350+}
scriptnum_ops 156
scriptpubkeyman [-22188-]{+22447+}
secp256k1_ec_seckey_import_export_der 2815
secp256k1_ecdsa_signature_parse_der_lax [-3843-]{+3855+}
service_deserialize 622
signature_checker 5459
signet [-7010-]{+7015+}
snapshotmetadata_deserialize 125
socks5 564
span 82
spanparsing 140
str_printf 985
string 2609
system [-2196-]{+2197+}
timedata 286
torcontrol [-1470-]{+1471+}
transaction [-8559-]{+8570+}
tx_in 442
tx_in_deserialize 250
tx_out 479
tx_package_eval [-11939-]{+11960+}
tx_pool [-16783-]{+16786+}
tx_pool_standard [-13348-]{+13347+}
txorphan 2427
txoutcompressor_deserialize [-1095-]{+1099+}
txrequest 2858
txundo_deserialize 1172
uint160_deserialize 113
uint256_deserialize 113
utxo_snapshot [-19326-]{+19337+}
utxo_total_supply [-21382-]{+21292+}
validation_load_mempool [-5562-]{+5569+}
versionbits 729
wallet_fees 432
wallet_notifications [-18954-]{+18984+}

@maflcko
Copy link
Contributor

maflcko commented Jan 30, 2024

The diff is noisy, but I guess this is only adding files, so can't hurt too much

@dergoegge dergoegge merged commit f1c86be into bitcoin-core:main Jan 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants