Skip to content

Add Murch’s inputs #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

murchandamus
Copy link
Contributor

@murchandamus murchandamus commented Oct 7, 2024

Add inputs via set_cover_merge from upstream and active fuzzing to create new corpora then adding back the upstream inputs as usual.

@maflcko
Copy link
Contributor

maflcko commented Oct 7, 2024

It does not include p2p_headers_presync, so I presume you've excluded it manually for now to avoid hitting the timeout bug?

@murchandamus
Copy link
Contributor Author

murchandamus commented Oct 7, 2024

I probably last pulled Bitcoin Core over three weeks ago, due to working on my BIP proposal and then being on vacation. So, given the timing of #207, I would guess that I just didn’t have a version with that fuzz target yet.

git reflog says I was on 0725a374941355349bb4bc8a79dad1affb27d3b9.

@murchandamus murchandamus marked this pull request as draft October 7, 2024 19:34
@maflcko
Copy link
Contributor

maflcko commented Oct 8, 2024

Happy to merge this one, or wait longer. Just let me know what you prefer. On a quick glance it looks like the runtime is larger by 30%, so this should hopefully add some coverage.

@murchandamus
Copy link
Contributor Author

murchandamus commented Oct 8, 2024

I am adding some fuzzing for p2p_headers_presync and clusterlin_make_connected, then merging again.

@dergoegge
Copy link
Member

Please don't add the p2p_headers_presync corpus it currently breaks the windows and macos ci.

@murchandamus murchandamus force-pushed the 2024-10-07-add-murchs-october-inputs branch from 2484d86 to ee21056 Compare October 8, 2024 13:28
@murchandamus murchandamus force-pushed the 2024-10-07-add-murchs-october-inputs branch from ee21056 to 1ace70e Compare October 8, 2024 16:07
@murchandamus
Copy link
Contributor Author

Alright, did some light fuzzing on clusterlin_make_connected and p2p_headers_presync, threw away p2p_headers_presync, did a fresh merge with the results from last nights fuzzing, now I think it should be good to go.

@murchandamus murchandamus marked this pull request as ready for review October 8, 2024 16:12
@maflcko maflcko merged commit 2e546ed into bitcoin-core:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants