ci: Turn persistent runners into GHA runners #236
Conversation
|
Looks like this needs actions enabled. @fanquake |
|
Should be enabled. |
|
Ah, I guess it needs to be merged, before it appears. Done in #237 |
I don't believe this is the case. It might be that actions are disabled on PRs from forks? |
|
I don't think we need restrictions in this repo on actions? But if so, we'd need them to say |
| file-env: './ci/test/00_setup_env_native_fuzz_with_msan.sh' | ||
| - name: 'fuzz (valgrind)' | ||
| runner: 'ubuntu-latest' | ||
| timeout-minutes: 360 |
There was a problem hiding this comment.
A lot less than was set in .cirrus! I believe that this is the maximum for Github's runners but if this ran on hosted runners it could be longer.
There was a problem hiding this comment.
I don't think there are hosted runners available right now in this repo, are there?
There was a problem hiding this comment.
No, but it could be nice to have? Especially if it's one pool shared between this org and /bitcoin org. Not sure this is currently possible on Cirrus but have asked the question.
There was a problem hiding this comment.
Ok. An alternative would be to purchase a second license with one runner (should be enough).
Yet another alternative could be warp-build or the pre-existing cirrus-ci (via cirrus.yml) with compute credits.
There was a problem hiding this comment.
Looks like the CI passed, so I guess it can be merged now. A follow-up can deal with possible follow-ups
There was a problem hiding this comment.
Cirrus have confirmed that we can share runners between orgs but they need to be contacted directly as this is a manual step for them.
There was a problem hiding this comment.
Cirrus have confirmed that we can share runners between orgs but they need to be contacted directly as this is a manual step for them.
Good to hear. I guess we can follow-up when there is need to. (I don't plan to follow-up here for now)
Should be able to retry. |
|
Would be good to get a review from either @m3dwards or @willcl-ark or someone else familiar with the CI , but otherwise I think this is rfm |
|
Code review ACK: fd2bd02 Would be nice to watch this after merging into master to check all the caches are working properly, especially because it reuses the cache actions from /bitcoin/bitcoin repo. |
It still fails with the same error as yesterday: bitcoin/bitcoin#31965 (comment) |
No description provided.