Skip to content

Conversation

practicalswift
Copy link
Contributor

Add seeds.

@@ -0,0 +1 @@
[true,true,true,true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fuzzer is only used to measure coverage of existing seeds. It can't be used to find new seeds because the seed format is fixed json

Copy link
Contributor

@sipa sipa Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I theory it could find seeds that increase coverage, but that's both unlikely to find much (due to the strong format constraints), and not particularly interesting (as it won't have valid/invalid markers that match consensus, so it can't be used as unit test data).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I handle the fuzzing and the submissions automatically. The assumption I've operated under previously is that everything returned by find src/test/fuzz/ -executable -type f is worth fuzzing. I'm now excluding script_assets_test_minimizer.

I predict this is not the last time someone will waste time on fuzzing script_assets_test_minimizer (and then submit seeds for it) :)

Perhaps compilation of script_assets_test_minimizer should be opt-in? Or simply be moved to another directory?

@practicalswift
Copy link
Contributor Author

Now excluding script_assets_test_minimizer seeds. Please re-review :)

@maflcko maflcko merged commit 91c6db1 into bitcoin-core:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants