-
Notifications
You must be signed in to change notification settings - Fork 72
Delete non-reduced fuzz inputs #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can be "reproduced" with:
|
Github is completely baffled by the size of the diff 🙈 |
I ran this twice and the difference was 7000 files, which is expected, because our fuzz targets are not deterministic |
I ran this and it seemed to achieve something similar to this PR; reducing the seed count by ~80'000: # master @ 3038a21dd7d6dfb3574401b8c76e48ca87c44769
find . -type f | wc -l
241321
./ delete_nonreduced_fuzz_inputs.sh
# git log
commit f08f63d6121d794b18213f71ead508649055a493 (HEAD -> master)
Author: delete_nonreduced_inputs script <noreply@noreply.noreply>
Date: Thu Jan 28 08:47:11 2021 +0000
Reduced inputs for fuzzer,address,undefined,integer
commit 12116b05479ba817f0b9c98e00ae3ddf47f0fbe3
Author: delete_nonreduced_inputs script <noreply@noreply.noreply>
Date: Thu Jan 28 07:42:43 2021 +0000
Reduced inputs for fuzzer
commit c9e492d4d9c1281aeb107b027205f895b35d6ec9
Author: delete_nonreduced_inputs script <noreply@noreply.noreply>
Date: Thu Jan 28 07:26:52 2021 +0000
Delete fuzz inputs
commit 3038a21dd7d6dfb3574401b8c76e48ca87c44769 (origin/master, origin/HEAD)
# find . -type f | wc -l (my reduced branch)
163311
# find . -type f | wc -l ( this branch @ ae401aa90e5e3fa996b4066cb067f23a26e51a4d)
163242 |
Ok, going to merge. If something went wrong, it is easy to revert. |
Post-merge ACK ae401aa: nice! :) |
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
fabeb5b fuzz: Disable shuffle when merge=1 (MarcoFalke) Pull request description: This should hopefully help make the deletion of fuzz inputs more deterministic. My tests (N=1) revealed that without this patch 7000 files differ (bitcoin-core/qa-assets#44 (comment)). With this patch, "only" 2000 files differ. ACKs for top commit: practicalswift: cr ACK fabeb5b: `-shuffle=0` and `-prefer_small=1` make sense Tree-SHA512: 21a701f52450d402a91dd6e0b33d564c63a9c3b919738eb9a80c24d48fc5b964088e325470738f39af0d595612c844acc7bf0941590cc2dc8c6f6ee4cb69c861
No description provided.