fix warcli down namespace
#501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josibake
reviewed
Aug 28, 2024
| @@ -123,7 +123,7 @@ def down(): | |||
| tanks = get_mission("tank") | |||
| with console.status("[yellow]Uninstalling tanks...[/yellow]"): | |||
| for tank in tanks: | |||
| cmd = f"helm uninstall {tank.metadata.name}" | |||
| cmd = f"helm uninstall {tank.metadata.name} --namespace {get_default_namespace()}" | |||
There was a problem hiding this comment.
I think this is fine for now, but leaving a comment for future self that we will need to rethink this if we are deploying commanders into a separate namespace.
There was a problem hiding this comment.
@josibake I'm going to merge then in order to get warcli down working.
As for commanders, perhaps we could concat get_default_namespace with '-commander', and place them in that namespace.
|
ACK 900920e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
warcli downwill throw an error such asSolution
Adding the default namespace to the command seems to fix this.