BIP141: New commitment structure, sigop limits, etc #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl2012
changed the title
|
ACK |
jl2012
force-pushed
the
bip141
branch
2 times, most recently
from
fea016a
to
349f88b
Compare
|
|
||
| The coinbase's input's witness must consist of a single byte array, which the size must be a multiple of 32 bytes but not bigger than 32*32 bytes. These are assumed to be the Merkle path to connect the witness root hash to the commitment root hash. Depth of the commitment is determined by the length of the path. If the depth of the tree is 0, the path should be represented by 0x00, and the witness root hash will be same as the commitment root hash. | ||
| A scriptPubKey (or redeemScript as defined in BIP16/P2SH) that consists of a 1-byte push opcode (for 0 to 16) followed by a data push between 2 and 32 bytes gets a new special meaning. The value of the first push is called the "version byte". The following byte vector pushed is called the "witness program". |
There was a problem hiding this comment.
Anything beyond 17 is two bytes, should it be called version byte?
There was a problem hiding this comment.
Only 0-16 are defined. Anything beyond 17 has no special meaning.
luke-jr
added a commit
that referenced
this pull request
Jan 12, 2016
BIP141: New commitment structure, sigop limits, etc
luke-jr
pushed a commit
to luke-jr/bips
that referenced
this pull request
Jan 20, 2018
Steal language from next_per_commitment_point requirements. Closes: bitcoin#277 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised based on the latest codebase:
https://github.com/sipa/bitcoin/commits/segwit2