Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallets that support RBF #994

Closed
wants to merge 1 commit into from
Closed

Add wallets that support RBF #994

wants to merge 1 commit into from

Conversation

@luke-jr
Copy link
Member

luke-jr commented Oct 5, 2020

@harding @petertodd

@harding
Copy link
Contributor

harding commented Oct 5, 2020

@prayank23 this section was meant to show that, at the time opt-in RBF was added to Bitcoin Core, no wallet's existing behavior would cause it to signal replacability (which its authors might not want). I don't think this section needs to be updated (allowing placement within historical context is one reason BIPs have creation dates), but if you do find this out-of-date information confusing, the section could start with something like "At the time opt-in RBF support was added to Bitcoin Core, no known wallet created [...]"

@maflcko
Copy link
Member

maflcko commented Oct 5, 2020

In newer BIPs this section is called "Backwards compatibility", see https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#specification

If this was unclear, maybe the section name can be changed as well?

@ghost
Copy link
Author

ghost commented Oct 5, 2020

Thanks for clarification

"At the time opt-in RBF support was added to Bitcoin Core, no known wallet created [...]"

If this was unclear, maybe the section name can be changed as well?

Either of the above can be done to avoid confusion in my opinion.

@harding
Copy link
Contributor

harding commented Oct 5, 2020

I think the name change suggested by @MarcoFalke is simplest and would be entirely effective. @prayank23 did you want to update your PR to make that change?

@ghost
Copy link
Author

ghost commented Oct 5, 2020

Client support
Backwards compatibility

No known wallet currently creates transactions by default with nSequence set below (0xffffffff - 1), so no known existing wallet explicitly signals replaceability by default. No known popular wallet spends other users' unconfirmed transactions by default, so no known existing wallets signals inherited replaceability.

At the time opt-in RBF support was added/proposed, no known wallet created transactions by default with nSequence set below (0xffffffff - 1), so no known wallet explicitly signaled replaceability by default. Also no known popular wallet spent other users' unconfirmed transactions by default, so no known wallets signaled inherited replaceability.

@harding does this look okay?

@harding
Copy link
Contributor

harding commented Oct 5, 2020

@prayank23 looks great!

@ghost
Copy link
Author

ghost commented Oct 5, 2020

Closing this PR. New PR: #1004 with branch name specific to change and update "client support" section as discussed.

@ghost ghost closed this Oct 5, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants