-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallets that support RBF #994
Conversation
@prayank23 this section was meant to show that, at the time opt-in RBF was added to Bitcoin Core, no wallet's existing behavior would cause it to signal replacability (which its authors might not want). I don't think this section needs to be updated (allowing placement within historical context is one reason BIPs have creation dates), but if you do find this out-of-date information confusing, the section could start with something like "At the time opt-in RBF support was added to Bitcoin Core, no known wallet created [...]" |
In newer BIPs this section is called "Backwards compatibility", see https://github.com/bitcoin/bips/blob/master/bip-0002.mediawiki#specification If this was unclear, maybe the section name can be changed as well? |
Thanks for clarification
Either of the above can be done to avoid confusion in my opinion. |
I think the name change suggested by @MarcoFalke is simplest and would be entirely effective. @prayank23 did you want to update your PR to make that change? |
At the time opt-in RBF support was added/proposed, no known wallet created transactions by default with nSequence set below (0xffffffff - 1), so no known wallet explicitly signaled replaceability by default. Also no known popular wallet spent other users' unconfirmed transactions by default, so no known wallets signaled inherited replaceability. @harding does this look okay? |
@prayank23 looks great! |
Closing this PR. New PR: #1004 with branch name specific to change and update "client support" section as discussed. |
Source:
https://bitcoinops.org/en/compatibility/#replace-by-fee-rbf
https://bluewallet.io/features/#rbf-cpfp
https://github.com/Fonta1n3/FullyNoded/blob/2976f47457ebb50af14e5e4d098560c99c123e18/Docs/Wallets/Sending.md#Replace-By-Fee