Skip to content

Commit

Permalink
Don't poll showmyip.com, it doesn't exist anymore
Browse files Browse the repository at this point in the history
Fixes #4679.

This leaves us with only one candidate, checkip.dyndns.org.
GetMyExternalIP should be phased out as soon as possible.

Rebased-From: c33b983
  • Loading branch information
laanwj committed Aug 18, 2014
1 parent 6862c8b commit 5332b0a
Showing 1 changed file with 1 addition and 20 deletions.
21 changes: 1 addition & 20 deletions src/net.cpp
Expand Up @@ -350,7 +350,7 @@ bool GetMyExternalIP(CNetAddr& ipRet)
const char* pszKeyword;

for (int nLookup = 0; nLookup <= 1; nLookup++)
for (int nHost = 1; nHost <= 2; nHost++)
for (int nHost = 1; nHost <= 1; nHost++)
{
// We should be phasing out our use of sites like these. If we need
// replacements, we should ask for volunteers to put this simple
Expand All @@ -375,25 +375,6 @@ bool GetMyExternalIP(CNetAddr& ipRet)

pszKeyword = "Address:";
}
else if (nHost == 2)
{
addrConnect = CService("74.208.43.192", 80); // www.showmyip.com

if (nLookup == 1)
{
CService addrIP("www.showmyip.com", 80, true);
if (addrIP.IsValid())
addrConnect = addrIP;
}

pszGet = "GET /simple/ HTTP/1.1\r\n"
"Host: www.showmyip.com\r\n"
"User-Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1)\r\n"
"Connection: close\r\n"
"\r\n";

pszKeyword = NULL; // Returns just IP address
}

if (GetMyExternalIP2(addrConnect, pszGet, pszKeyword, ipRet))
return true;
Expand Down

0 comments on commit 5332b0a

Please sign in to comment.