Skip to content

Commit

Permalink
Re-add BTC/KB in help message for settxfee
Browse files Browse the repository at this point in the history
Commit a22eed6 got reverted in a RPC documentation update, redo it.
  • Loading branch information
laanwj committed Jan 29, 2014
1 parent de9b4c7 commit a7f3aed
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/rpcwallet.cpp
Expand Up @@ -1850,9 +1850,9 @@ Value settxfee(const Array& params, bool fHelp)
if (fHelp || params.size() < 1 || params.size() > 1)
throw runtime_error(
"settxfee amount\n"
"\nSet the transaction fee. 'amount' is a real and is rounded to the nearest 0.00000001\n"
"\nSet the transaction fee per KB.\n"
"\nArguments:\n"
"1. amount (numeric, required) The transaction fee in btc rounded to the nearest 0.00000001\n"
"1. amount (numeric, required) The transaction fee in BTC/KB rounded to the nearest 0.00000001\n"
"\nResult\n"
"true|false (boolean) Returns true if successful\n"
"\nExamples:\n"
Expand Down

4 comments on commit a7f3aed

@Diapolo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laanwj This should be kB, because we use 1000 bytes as base. 1024 bytes would be KB.

@laanwj
Copy link
Member Author

@laanwj laanwj commented on a7f3aed Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes technically it should be kB, however this is a big improvement over the original which did not mention a unit at all.
A 'KB' doesn't exist. What you're refering to would be 'KiB'.

@Diapolo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use all over the code KB for 1024 (even if there are not many places) and kB for 1000. I just wanted to ensure to keep it consistent or update every place with KB/KiB, MB/MiB or GB/GiB.

@sipa
Copy link
Member

@sipa sipa commented on a7f3aed Jan 30, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.