Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Re-add BTC/KB in help message for
settxfee
Commit a22eed6 got reverted in a RPC documentation update, redo it.
- Loading branch information
a7f3aed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laanwj This should be
kB
, because we use 1000 bytes as base. 1024 bytes would beKB
.a7f3aed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes technically it should be
kB
, however this is a big improvement over the original which did not mention a unit at all.A 'KB' doesn't exist. What you're refering to would be 'KiB'.
a7f3aed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use all over the code KB for 1024 (even if there are not many places) and kB for 1000. I just wanted to ensure to keep it consistent or update every place with KB/KiB, MB/MiB or GB/GiB.
a7f3aed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.