New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cost too many fees? #10247
Comments
Please use something like http://bitcoin.stackexchange.com for future user questions. This is the development issue tracker. It looks like that your fee estimation spits out a relatively high value. |
I think this question have its place here, it might have been a bug. |
You should definitely upgrade to 0.14.0, but it is still possible although rare for such a result to happen. Do you know what your transaction confirm target was set to? The default in 0.12 was changed to 2, but if you are running the GUI, then the GUI setting from a previous version may have persisted. This kind of result is much more likely with a target of 1 than with a target of 2. |
I use ubuntu server only , and install from tarball binary(not compiler by my self) , and I send 5 transactions same time at 3 node(different VM) , same config same amount same version , nodeA x 3 , nodeB x 1 , nodeC x 1 , and it only happen in nodeA
hmm ...... anyway I'll upgrade my node , and add confirm target(maybe 4) , and maybe rebuild the nodeA & thanx @morcos recommand : ) , first post is my all config file , so I think it's default value ... |
Those are really very high values, so I am a bit curious how that could have happened. But this is a good reminder that we should record more debugging information by default in the log when a transaction automatically uses fee estimation. |
Having fee estimation more auditable would be a great idea. |
hmm @morcos it's my production node , it run over 2 month ... but I write my code to make & send rawtransaction to clear dust (very low fee) , but this time is some emergency things must immediately to send , so I send it from terminal so it possible the fee calculate weight include another older transaction like manual to send rawtransaction ? even no relation with another non-used vouts ? & just I say , picked vouts all over 50 comfirms |
I would like to point out:
|
just to note: A user on IRC last night reported extremely high fees(2,000+ sat/byte) a couple times using |
Did they set subtract_fee_from_amount=True? That is still an open issue:
https://github.com/bitcoin/bitcoin/blob/80c3a734298e824f9321c4efdd446086a3baad89/src/wallet/wallet.cpp#L2627
…On Sun, Apr 30, 2017 at 3:58 PM, Gregory Sanders ***@***.***> wrote:
just to note: A user on IRC last night reported extremely high fees(2,000+
sat/byte) a couple times using sendmany on 0.14.1 even though settxfee
was set.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10247 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv8l7hG66vIpifetrAsuNdM32kxtlks5r1JOcgaJpZM4ND3PA>
.
|
@MarcoFalke I did not set subtract_fee_from_amount. I'm just simply using sendmany to multiple addresses. It appears to me as it ate the rest of the change for the fee in all cases. My inputs vary widely in size, there are usually a few inputs less than 0.05 for it to choose from when building it, usually from existing change. 80% of the time it usually comes up with an input set that is within ~0.01 of the output sum plus fee. Additionally, occasionally sendtoaddress would send with a fee a bit higher than I expected, decided to try sendmany to reduce fees and combine individual sends into a single transaction. Using this in a production environment, not expecting bitcoin core to have issues like this. |
@MarcoFalke It may be the line two lines down: Line 2630 in 80c3a73
Since he has no change in his transactions with such a high fee. |
@JokerCatz If you run |
I have 4 full node : [777 , 454 , 390 , 225] |
As mentioned on IRC https://botbot.me/freenode/bitcoin-core-dev/2017-05-04/?msg=85156140&page=2 , I think its still possible for the old coin selection problem to rear it's head. I'm not sure exactly how rare it is, but should be significantly less common than it used to be. |
@JokerCatz You have a lot of unspent on all your nodes, you really should upgrade them all ASAP. In total I've lost over a bitcoin in total due to the bug that was fixed (or at least, heavily mitigated), it'll probably be affecting you often when you send money |
Since this issue appears to be the "no change" situation, it's likely not mitigated yet. |
@RHavar my production normally use rawtransaction send and clear dust , so it not problem & thanx , I'll upgrade my all node next week , just it look like bug & report it |
Is there any update on this issue? |
@JokerCatz Did you test with a 0.15 release candidate? It would be interesting to see if it fixes your problem. |
Hi , I'm so sorry , my project is fixed , use rawtransaction to send transaction & calculate fees... so I think I can't test this issue ... |
I think this can be closed |
I am also having this problem, I may be able to test the actual release
though. I havent kept up on when that would be. I run live environment, so
may be a while till I can get an answer. I do however see many other
incoming transactions having the same fee overpayment issue from time to
time.
…On Sep 7, 2017 1:00 PM, "Alex Morcos" ***@***.***> wrote:
I think this can be closed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10247 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABaLWkuM5WJbnQc3XTG05BDI67n0KbUDks5sgC5TgaJpZM4ND3PA>
.
|
@cncr04s 0.15/master should catch any of these types of vast overpayment errors. |
@cncr04s If you are running 0.14, then it should be very relatively rare to have overpayment issues, but they can still exist when you have a transaction without change. That edge case should be fixed in 0.15. If you have this problem on 0.14 node on a transaction with change, please provide us with us much information as you can. |
at least 0.15.1 is not doing overpayment, with
|
@Safari77 did your mempool size is too small ? & is sync finished ? or offline signature ? , I tried use |
@Safari77 When it says that the reason is "Fallback Fee" that means fee estimation is not working. |
Well I definitely was not inspecting debug.log before sending the transaction in GUI after it synced and also didn't have an idea about that 4-5 block "rule"... So my only option is to quit bitcoin-qt, delete |
No do not delete your mempool data. Let your node run for a while and it
will fix itself.
…On Dec 10, 2017 9:58 AM, "Sami Farin" ***@***.***> wrote:
Well I definitely was not inspecting debug.log before sending the
transaction in GUI *after* it synced and also didn't have an idea about
that 4-5 block "rule"...
So my only option is to quit bitcoin-qt, delete mempool.dat, and start
bitcoin-qt again?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10247 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC02g-zN9LKc-zM3dvHsfSmwMSyP5Lks5s-_GogaJpZM4ND3PA>
.
|
@Safari77 Just to clarify, i was suggesting that if you sent transaction from bitcoin-qt you should have seen something like this and there should have been no need to inspect debug.log: But @instagibbs is right, you should not need to do anything to "fix" the problem. You should be able to see from bitcoin-qt that the estimates are more reasonable now. |
Yes, it now suggests Transaction Fee 0.0019... |
Yeah that’s not a bad idea BTW you can use bumpfee if you had RBF enabled and want to pay more fee to get it confirmed faster. |
Thing that could be improved: a) Don't allow to send transactions when fee estimation is not initialised I prefere c. |
I like (c), or (b) at a minimum. (a) is a non-starter, if nothing else because that would make regtest hard to use |
I wouldn't force BIP125-RBF, but additional popup warning could strongly recommend it |
Can we add a API function that estimates the fee. I looked at the code and there is such an internal function, ie it creates the transaction object then sends it to the network. I propose that the estimate fee would just return the created transaction without relaying it to the network. This way, users can decide for them selves if the fee being paid is appropriate for their needs. |
@cncr04s We have |
@sipa I'm not sure that applies to a sendtoaddress request. I want to know how much fee is paid in the sendtoaddress before its actually sent. I don't know what inputs it selects/ the size of the transaction and therefore can't calculate the fee using estimatesmartfee. |
@cncr04s You can use |
To the best of my knowledge this issue can be closed, as we fixed all known instances of "excessive fee-rate", i.e. accidentally creating a transaction that pays more satoshis per byte in fees than it should (taking into account the target fee rate). The issue that coin selection will yield a very unfortunate subset of coins, and cause an "excessive overall fee", i.e. a transaction which spends many "uneconomical coins" is tracked in #1643. The issue that fallbackfee silently results in "insufficient fee-rate or overall fee" is a completely separate issue and should be tracked on a separate ticket. Solutions to improve the fallbackfee situations are proposed in: #11918, #11882, #11892, #9481 (merged in 0.15) |
@MarcoFalke okay & why not , many thanx dev team :) |
Hi , I send a transaction , but it cost 5,209.456 sat/B ...... & used txin all over 50 confirms
https://blockchain.info/tx/37f98737fe28f1f29840926edeb9cb3a85eb9496070048eb98f2523d612c3cfb
and my getinfo
& my config
did it just version too old & need to upgrade?
The text was updated successfully, but these errors were encountered: