Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CCoinsMap from boost to std unordered_map #10249

Merged
merged 2 commits into from
Apr 24, 2017
Merged

Switch CCoinsMap from boost to std unordered_map #10249

merged 2 commits into from
Apr 24, 2017

Conversation

sipa
Copy link
Member

@sipa sipa commented Apr 21, 2017 •
edited
Loading

Rely less on Boost. There is no pressing reason for this now, but it'd be nice to have it for #10195.

@sipa sipa mentioned this pull request Apr 21, 2017
Merged
@jonasschnelli
Copy link
Contributor

utACK e6756ad

1 similar comment
@theuni
Copy link
Member

theuni commented Apr 21, 2017

utACK e6756ad

@instagibbs
Copy link
Member

utACK e6756ad

gmaxwell
gmaxwell approved these changes Apr 21, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very useful utACK.

@TheBlueMatt
Copy link
Contributor

utACK e6756ad die boost.

dcousens
dcousens approved these changes Apr 22, 2017
View reviewed changes
Copy link
Contributor

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@jtimon
Copy link
Contributor

jtimon commented Apr 24, 2017 •
edited
Loading

utACK e6756ad
Will the first commit pass individually? If not, maybe better squash.

@sipa
Copy link
Member Author

sipa commented Apr 24, 2017

@jtimon I haven't tried but I don't see why not. It just adds some things to memusage...

@sipa sipa merged commit e6756ad into bitcoin:master Apr 24, 2017
sipa added a commit that referenced this pull request Apr 24, 2017
@sipa
Merge #10249: Switch CCoinsMap from boost to std unordered_map
c73af54 
e6756ad Switch CCoinsMap from boost to std unordered_map (Pieter Wuille)
344a2c4 Add support for std::unordered_{map,set} to memusage.h (Pieter Wuille)

Tree-SHA512: 51288301e7c0f29ffac8c59f4cc73ddc36b7abeb764009da6543f2eaeeb9f89bd47dde48131a7e0aefad8f7cb0b74b2f33b8be052c8e8a718339c3e6bb963447
@sipa
Copy link
Member Author

sipa commented Apr 24, 2017

die boost.

I always interpret such statements as German.

@sipa sipa deleted the stdcoinmap branch June 23, 2017 00:37
@jnewbery jnewbery mentioned this pull request Jul 31, 2017
Closed
12 tasks
@codablock codablock mentioned this pull request Oct 30, 2017
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Oct 31, 2017
@sipa @codablock
Merge bitcoin#10249: Switch CCoinsMap from boost to std unordered_map
afa96b7 
e6756ad Switch CCoinsMap from boost to std unordered_map (Pieter Wuille)
344a2c4 Add support for std::unordered_{map,set} to memusage.h (Pieter Wuille)

Tree-SHA512: 51288301e7c0f29ffac8c59f4cc73ddc36b7abeb764009da6543f2eaeeb9f89bd47dde48131a7e0aefad8f7cb0b74b2f33b8be052c8e8a718339c3e6bb963447
@dagurval dagurval mentioned this pull request Apr 12, 2018
Merged
@random-zebra random-zebra mentioned this pull request Aug 9, 2020
Merged
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Aug 12, 2020
@random-zebra
Merge #1795: [Core] Use unordered_map for CCoinsMap and fix empty vec…
afafd7f 
…tors in streams

9f39dc8 Switch CCoinsMap from boost to std unordered_map (Pieter Wuille)
2f58a63 Add support for std::unordered_{map,set} to memusage.h (Pieter Wuille)
60c8cef Fix some empty vector references (random-zebra)

Pull request description:

  Couple of quick backports (needed for the upcoming per-txout model for cache and chainstate db):

  - bitcoin#10249 - Switch CCoinsMap from boost to std unordered_map
  - bitcoin#10250 - Fix some empty vector references

ACKs for top commit:
  furszy:
    utACK 9f39dc8
  Fuzzbawls:
    ACK 9f39dc8

Tree-SHA512: 9af7ad25d0066883a42ccacc26252fded20b80a875a6e282ea173a484031da9c2719c1feec699157aa22774d13c241f5c21312a8e38749d67c9c8c2e2ff592cb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcousens dcousens dcousens approved these changes

@gmaxwell gmaxwell gmaxwell approved these changes

Assignees
No one assigned
Labels
UTXO Db and Indexes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sipa @jonasschnelli @theuni @instagibbs @TheBlueMatt @jtimon @dcousens @gmaxwell @laanwj