Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin-Qt project file - used identifiers (windows / mac) #1573

Closed
Diapolo opened this issue Jul 9, 2012 · 6 comments
Closed

Bitcoin-Qt project file - used identifiers (windows / mac) #1573

Diapolo opened this issue Jul 9, 2012 · 6 comments

Comments

@Diapolo
Copy link

Diapolo commented Jul 9, 2012

We use the keyword windows a lot in the project file, but I'm not sure if this is supported / correct. I was not able to find a reliable source that sheds some light on my question.

See:
http://doc.qt.nokia.com/4.7-snapshot/qmake-advanced-usage.html

There is always win32 mentioned. Same for mac, which should perhaps be macx.

Anyway, I tried replacing all occurrences of windows with win32 and it compiles fine on my local setup. Perhaps a main dev can take a look at this.
@laanwj
Copy link
Member

laanwj commented Jul 10, 2012

It seems to work fine right now. Maybe WINDOWS is general windows, and
WIN32 is 32 bit apecific?

@laanwj
Copy link
Member

laanwj commented Jul 10, 2012

http://stackoverflow.com/questions/356666/identifier-for-win64-configuration-in-qmake

Strange, so win64 is win32 too according to qmake.

@Diapolo
Copy link
Author

Diapolo commented Jul 10, 2012

And I don't see windows mentioned over there in the posting.

@Diapolo
Copy link
Author

Diapolo commented Sep 28, 2012

Alright, no more mac occurances are in the pro-file now. Next thing I'd like to do is switch all windows to win32 and as we now have the pull tester this should be easy to verify it breaks nothing :).

@Diapolo
Copy link
Author

Diapolo commented Jan 6, 2013

Should be fixed by #2109.

@Diapolo
Copy link
Author

Diapolo commented Jan 26, 2013

Resolved, so closing this.

@Diapolo Diapolo closed this as completed Jan 26, 2013
lateminer pushed a commit to lateminer/bitcoin that referenced this issue May 6, 2020
@furszy
Merge bitcoin#1573: [Doc] Note that v3 onion addresses are not supported
f973fb6 
c31b056 [Doc] Note that v3 onion addresses are not supported (Fuzzbawls)

Pull request description:

  v3 onion addresses are 256 bits, which is currently beyond what our P2P
  protocol allows in `addr` messages. Until such time that [BIP155](https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) can be
  implemented, note in the tor.md doc that the `-externalip` configuration
   flag should not be used with v3 onion addresses.

ACKs for top commit:
  random-zebra:
    utACK c31b056
  furszy:
    utACK c31b056

Tree-SHA512: 7a4343f8ca3cbf2749681c72d35014f562e79626b02ab5ddae8e2ee851d241ac706cb167756a6e6a11329c96b5d6326523dc650d1e80e9449fa9cc4eb9c76375
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laanwj @Diapolo