New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use zip instead of dmg for macOS #18128
Comments
My 5cts on this:
I personally would ack a move from .dmg to zip. I don't think we have to deal with users not knowing how to move an .app bundle form the downloads folder to the application folder. Additionally, it (the .zip approach) may simplify macOS app notarization. |
Ah yes, a
|
I'd suggest to stick with the .dmg, just because some users really don't know that .apps should go in Applications/. Though, your point makes sense. Zipping the .dmg isn't a particularly good option either. Maybe include a README with 'installation steps' (one move) in the zipped .app? |
I agree with @ch4ot1c that some users may not know that the app needs to be moved to |
@jonasschnelli Can you give some examples? I had a quick look around, and Firefox, Google Chrome, Tor, VLC, Transmission, VirtualBox etc all still use a I'm still not entirely sure, but could probably be convinced that the reduction in build-system complexity is worth the trade-off in "branding". I might put those changes together as an alternative to/alongside #18151. |
After some more thought I think this is the way forward, and have pretty much finished up the changes required to switch to using a |
~0 on this. I like the simplification in build system complexity, but on the other hand, |
GitHub Desktop uses zips instead of dmgs: https://desktop.github.com/ |
my 2cnts, the move to a
|
We simplified the creation of
Do we still want to consider moving from |
I don't think we'll make the move from dmg to zip yet, but I have opened another PR (#24031) which I think makes an OK tradeoff in regards to removing additional dependencies / build complexity from the macOS build. |
Updated the op to refect build changes since it was first written. |
Opened a new PR to discuss this change in #27099. |
b5790c3 build: remove dmg dependencies (fanquake) 33ae0bd macdeploy: remove DMG generation from deploy script (fanquake) a128111 build: produce a .zip for macOS distribution (Hennadii Stepanov) c38561d build: add -zip option to macdeployqtplus (fanquake) Pull request description: It is #27099 revived with addressed [comments](#27099 (comment)). From #27099 (comment): > Reviving the discussion around using a `.zip` for the distributed macOS binaries, as opposed to a `.dmg`. > > Given we only had a single report of the "no finder window" issue (#26176), I wonder if that means macOS users were able to figure it out, they gave up/didn't report, or, we just have very few macOS users. > > Related to #18128. That's how it looks on macOS: ![image](https://github.com/bitcoin/bitcoin/assets/32963518/baa637bb-256b-4b24-8645-8c2754c2ae64) ACKs for top commit: Sjors: tACK b5790c3 jarolrod: ACK b5790c3 TheCharlatan: utACK b5790c3 Tree-SHA512: 6e9cb3ab0f60f8a92bfec50577e8d096c5b23ec09ebbb334826415609140ddc96d470aea37379495c1c6bb1beec0d306b09460f62e1543bb0f4396c10a1dfbe2
Anything left to be done here? If yes, maybe open a new issue? |
Since macOS is able to to extract tarballs with a double-click, I'm wondering what people's thoughts are on using zip instead of dmg for macOS builds.
This will eliminate the following build dependencies:
A valid concern is one of UX, which might be worse.
Here were the steps to installing Bitcoin in a DMG world:
tarballzip world steps:tarballzipping @fanquake
The text was updated successfully, but these errors were encountered: