build: produce a .zip for macOS distribution #27099
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK At present, the user experience with DMG is terrible (as noted in this issue: #26176). If there's no straightforward solution on the horizon, it would be best to switch to using ZIP instead. Using DMG without a Finder window provides no advantages and only leads to a lot of confusion. As evidence, Visual Studio Code has recently started distributing their macOS builds as ZIP files instead of DMGs, as you can see on their download page: https://code.visualstudio.com/Download. |
|
Concept ACK tested on macOS 12.6.1 (21G217) Python 3.10.9 |
|
Concept ACK, I second @prusnak. |
|
Concept ACK |
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
49336b1
to
ba3237b
Compare
|
Rebased past #27172. |
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
ba3237b
to
c5342f0
Compare
|
A few Concept ACKs here, so have rebased and undrafted. |
|
This is definitely nicer. When you doubleclick on the zip file it magically reveals the orange icon:
The only thing we need to remind the user of, is to drag it to their applications folder. Worst case: they forget, sync a node, delete everything in the download folder. This won't delete the blockchain or their wallet, which are stored elsewhere. Simply redownload and it will work again. But it may scare users. It's the same as with other macOS applications. In a followup we could improve this further by moving everything in the archive into a folder. That folder could contain a README, and we could even include bitcoin-cl, bitcoind and (more important perhaps) bitcoin-wallet somewhere. |
|
The above was done with |
|
note: |
I'm pretty sure we can assume that on macOS. |
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
c5342f0
to
6e313c6
Compare
|
Rebased, and added a number of small doc fixups. |
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
6e313c6
to
e82e731
Compare
|
When I do
It seems like only the zip file needs to be there? |
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
6dd29d9
to
8a6275b
Compare
|
Tested I think a couple of comments still need to be addressed: |
|
tACK 8a6275b Tested that it produces a working zip / binary for me on Intel macOS 13.5.1, both when using |
This zips the app bundle in /dist.
Instead of a .dmg.
fanquake
force-pushed
the
macdeploy_use_zip
branch
from
8a6275b
to
11f8b6b
Compare
|
Having an error when building Guix: |
|
Someone else can take this over if interested. |
|
Difference between my ACK and the last push: Getting the same (?) error as @hebasto now :-( If anyone takes this over, please ping me. |
|
Picked in #28432. |
b5790c3 build: remove dmg dependencies (fanquake) 33ae0bd macdeploy: remove DMG generation from deploy script (fanquake) a128111 build: produce a .zip for macOS distribution (Hennadii Stepanov) c38561d build: add -zip option to macdeployqtplus (fanquake) Pull request description: It is #27099 revived with addressed [comments](#27099 (comment)). From #27099 (comment): > Reviving the discussion around using a `.zip` for the distributed macOS binaries, as opposed to a `.dmg`. > > Given we only had a single report of the "no finder window" issue (#26176), I wonder if that means macOS users were able to figure it out, they gave up/didn't report, or, we just have very few macOS users. > > Related to #18128. That's how it looks on macOS:  ACKs for top commit: Sjors: tACK b5790c3 jarolrod: ACK b5790c3 TheCharlatan: utACK b5790c3 Tree-SHA512: 6e9cb3ab0f60f8a92bfec50577e8d096c5b23ec09ebbb334826415609140ddc96d470aea37379495c1c6bb1beec0d306b09460f62e1543bb0f4396c10a1dfbe2
Reviving the discussion around using a
.zipfor the distributed macOS binaries, as opposed to a.dmg.Given we only had a single report of the "no finder window" issue (#26176), I wonder if that means macOS users were able to figure it out, they gave up/didn't report, or, we just have very few macOS users.
Related to #18128.