test: failure in test/functional/feature_rbf.py with `--without-bdb` #23563

fanquake · 2021-11-21T09:27:25Z

master @ cf06c9b

./autogen.sh
./configure --without-bdb
make -j9

./test/functional/feature_rbf.py                  
2021-11-21T09:25:15.472000Z TestFramework (INFO): Initializing test directory /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6
2021-11-21T09:25:16.098000Z TestFramework (INFO): Running test simple doublespend...
2021-11-21T09:25:16.104000Z TestFramework (INFO): Running test doublespend chain...
2021-11-21T09:25:16.152000Z TestFramework (INFO): Running test doublespend tree...
2021-11-21T09:25:16.770000Z TestFramework (INFO): Running test replacement feeperkb...
2021-11-21T09:25:16.841000Z TestFramework (INFO): Running test spends of conflicting outputs...
2021-11-21T09:25:16.860000Z TestFramework (INFO): Running test new unconfirmed inputs...
2021-11-21T09:25:16.869000Z TestFramework (INFO): Running test too many replacements...
2021-11-21T09:25:16.959000Z TestFramework (INFO): Running test opt-in...
2021-11-21T09:25:16.978000Z TestFramework (INFO): Running test RPC...
2021-11-21T09:25:16.999000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "./test/functional/feature_rbf.py", line 79, in run_test
    self.test_rpc()
  File "./test/functional/feature_rbf.py", line 544, in test_rpc
    frawtx2a = self.nodes[0].fundrawtransaction(rawtx2, {"replaceable": True})
  File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/coverage.py", line 49, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/authproxy.py", line 144, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Insufficient funds (-4)
2021-11-21T09:25:17.056000Z TestFramework (INFO): Stopping nodes
2021-11-21T09:25:17.216000Z TestFramework (WARNING): Not cleaning up dir /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6
2021-11-21T09:25:17.216000Z TestFramework (ERROR): Test failed. Test logging available at /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_dzacmtp6/test_framework.log

The text was updated successfully, but these errors were encountered:

maflcko · 2021-11-22T09:31:23Z

Can be worked around by:

diff --git a/test/functional/feature_rbf.py b/test/functional/feature_rbf.py
index e540cc157..a2f07ca46 100755
--- a/test/functional/feature_rbf.py
+++ b/test/functional/feature_rbf.py
@@ -540,6 +540,7 @@ class ReplaceByFeeTest(BitcoinTestFramework):
 
         if self.is_wallet_compiled():
             self.init_wallet(node=0)
+            self.nodes[0].rescanblockchain()
             rawtx2 = self.nodes[0].createrawtransaction([], outs)
             frawtx2a = self.nodes[0].fundrawtransaction(rawtx2, {"replaceable": True})
             frawtx2b = self.nodes[0].fundrawtransaction(rawtx2, {"replaceable": False})

… to test runner b79dbe8 test: add feature_rbf.py --descriptors to test_runner.py (Sebastian Falbesoner) 166f8ec test: always rescan after importing private keys in `init_wallet` helper (Sebastian Falbesoner) Pull request description: The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, a call to the helper `init_wallet` https://github.com/bitcoin/bitcoin/blob/111c3e06b35b7867f2e0f740e988f648ac6c325d/test/functional/test_framework/test_framework.py#L428-L434 creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with `rescan=True`, which calls importdescriptors with timestamp=0. Also add `feature_rbf.py --descriptors` to the list of the test runner's calls. Fixes bitcoin#23563. ACKs for top commit: mjdietzx: ACK b79dbe8 Tree-SHA512: a3f3f7a4077066e3c910919d3b5e04bc6b580c1e0a06e9a2fc258950eaea5e59c0f805c8f00432aea722609f2f7e41eebfab653471b76729c5a316825a3d8c86

fad2e0a ci: Make macOS native task sqlite only (MarcoFalke) Pull request description: There are many sqlite-only test failures (#23563, #23562), so make one CI task sqlite-only. Obviously this removes bdb coverage from macOS, but I don't expect this to break very often. ACKs for top commit: fanquake: ACK fad2e0a - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a `--without-bdb` build on macOS and Linux. Tree-SHA512: d88ad576bbe974a51a2d115e4102fc1bd73772b7393dfa99700fbfd1bdf5deebbf247e35d09757639649a6ad5b193c0998c7db679301a7c012572dfd54a6a289

fad2e0a ci: Make macOS native task sqlite only (MarcoFalke) Pull request description: There are many sqlite-only test failures (bitcoin#23563, bitcoin#23562), so make one CI task sqlite-only. Obviously this removes bdb coverage from macOS, but I don't expect this to break very often. ACKs for top commit: fanquake: ACK fad2e0a - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a `--without-bdb` build on macOS and Linux. Tree-SHA512: d88ad576bbe974a51a2d115e4102fc1bd73772b7393dfa99700fbfd1bdf5deebbf247e35d09757639649a6ad5b193c0998c7db679301a7c012572dfd54a6a289

… to test runner b79dbe8 test: add feature_rbf.py --descriptors to test_runner.py (Sebastian Falbesoner) 166f8ec test: always rescan after importing private keys in `init_wallet` helper (Sebastian Falbesoner) Pull request description: The functional test feature_rbf.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, a call to the helper `init_wallet` https://github.com/bitcoin/bitcoin/blob/111c3e06b35b7867f2e0f740e988f648ac6c325d/test/functional/test_framework/test_framework.py#L428-L434 creates a wallet without rescanning the blockchain; the test framework maps the importprivkey RPC calls to the importdescriptors RPC without rescanning by default (timestamp='now'). Fix this by always calling with `rescan=True`, which calls importdescriptors with timestamp=0. Also add `feature_rbf.py --descriptors` to the list of the test runner's calls. Fixes bitcoin#23563. ACKs for top commit: mjdietzx: ACK b79dbe8 Tree-SHA512: a3f3f7a4077066e3c910919d3b5e04bc6b580c1e0a06e9a2fc258950eaea5e59c0f805c8f00432aea722609f2f7e41eebfab653471b76729c5a316825a3d8c86

fanquake added the Tests label Nov 21, 2021

theStack mentioned this issue Nov 26, 2021

test: fix feature_rbf.py --descriptors and add to test runner #23608

Merged

fanquake closed this as completed in 4f8b1f8 Nov 28, 2021

maflcko mentioned this issue Dec 6, 2021

ci: Make macOS native task sqlite only #23682

Merged

bitcoin locked and limited conversation to collaborators Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: failure in test/functional/feature_rbf.py with `--without-bdb` #23563

test: failure in test/functional/feature_rbf.py with `--without-bdb` #23563

fanquake commented Nov 21, 2021

maflcko commented Nov 22, 2021

test: failure in test/functional/feature_rbf.py with --without-bdb #23563

test: failure in test/functional/feature_rbf.py with --without-bdb #23563

Comments

fanquake commented Nov 21, 2021

maflcko commented Nov 22, 2021

test: failure in test/functional/feature_rbf.py with `--without-bdb` #23563

test: failure in test/functional/feature_rbf.py with `--without-bdb` #23563