Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wallet_transactiontime_rescan.py failure with --without-bdb #23562

Closed
fanquake opened this issue Nov 21, 2021 · 0 comments · Fixed by #23596
Closed

test: wallet_transactiontime_rescan.py failure with --without-bdb #23562

fanquake opened this issue Nov 21, 2021 · 0 comments · Fixed by #23596
Labels

Comments

@fanquake
Copy link
Member

master @ cf06c9b

./autogen.sh
./configure --without-bdb
make -j9

./test/functional/wallet_transactiontime_rescan.py
2021-11-21T09:09:22.057000Z TestFramework (INFO): Initializing test directory /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_vilmgmza
2021-11-21T09:09:22.950000Z TestFramework (INFO): Prepare nodes and wallet
2021-11-21T09:09:23.018000Z TestFramework (INFO): Start transactions
2021-11-21T09:09:24.212000Z TestFramework (INFO): Send 10 btc to user
2021-11-21T09:09:24.472000Z TestFramework (INFO): Send 5 btc to user
2021-11-21T09:09:25.834000Z TestFramework (INFO): Send 1 btc to user
2021-11-21T09:09:27.166000Z TestFramework (INFO): Check user's final balance and transaction count
2021-11-21T09:09:27.168000Z TestFramework (INFO): Check transaction times
2021-11-21T09:09:27.168000Z TestFramework (INFO): Restore user wallet on another node without rescan
2021-11-21T09:09:27.191000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "./test/functional/wallet_transactiontime_rescan.py", line 134, in run_test
    assert_equal(restorewo_wallet.getbalance(), 0)
  File "/Users/michael/github/fanquake-bitcoin/test/functional/test_framework/util.py", line 50, in assert_equal
    raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(1.00000000 == 0)
2021-11-21T09:09:27.246000Z TestFramework (INFO): Stopping nodes
2021-11-21T09:09:27.454000Z TestFramework (WARNING): Not cleaning up dir /var/folders/z2/cn877pxd3czdfh47mfkmbwgm0000gn/T/bitcoin_func_test_vilmgmza
@fanquake fanquake added the Tests label Nov 21, 2021
@maflcko maflcko closed this as completed in 32d9f37 Dec 6, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Dec 7, 2021
…scriptors` and add to test runner

e4a54af  test: add wallet_transactiontime_rescan.py --descriptors to test_runner.py (Sebastian Falbesoner)
b60e02e test: fix test wallet_transactiontime_rescan.py for descriptor wallets (Sebastian Falbesoner)
a905ed1 test: refactor: use `set_node_times` helper in wallet_transactiontime_rescan.py (Sebastian Falbesoner)

Pull request description:

  The functional test wallet_transactiontime_rescan.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`). This is due to the fact that in this case, the test framework maps the importaddress RPC calls to the importdescriptors RPC (rescan=False -> timestamp='now'), which always rescans blocks of the past 2 hours, based on the current MTP timestamp. In order to avoid importing the last address (wo3), we generate 10 more blocks with advanced time, to ensure that the balance after importing is zero:
  https://github.com/bitcoin/bitcoin/blob/681b25e3cd7d084f642693152322ed9a40f33ba0/test/functional/wallet_transactiontime_rescan.py#L125-L134

  Calling this test with descriptor wallets is also added to test runner. Fixes bitcoin#23562.

ACKs for top commit:
  Sjors:
    tACK e4a54af
  brunoerg:
    tACK e4a54af

Tree-SHA512: 9fd8e298d48dd7947b1218d61a1a66c1241b3dbb14451b0ec7cd30caa74ee540e7ee5a7bd10d421b9e3b6e549fa5c3e85bd02496436128b433b328118642f600
maflcko pushed a commit to maflcko/bitcoin-core that referenced this issue Dec 10, 2021
fad2e0a ci: Make macOS native task sqlite only (MarcoFalke)

Pull request description:

  There are many sqlite-only test failures (bitcoin#23563, bitcoin#23562), so make one CI task sqlite-only.

  Obviously this removes bdb coverage from macOS, but I don't expect this to break very often.

ACKs for top commit:
  fanquake:
    ACK fad2e0a - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a `--without-bdb` build on macOS and Linux.

Tree-SHA512: d88ad576bbe974a51a2d115e4102fc1bd73772b7393dfa99700fbfd1bdf5deebbf247e35d09757639649a6ad5b193c0998c7db679301a7c012572dfd54a6a289
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Dec 10, 2021
fad2e0a ci: Make macOS native task sqlite only (MarcoFalke)

Pull request description:

  There are many sqlite-only test failures (bitcoin#23563, bitcoin#23562), so make one CI task sqlite-only.

  Obviously this removes bdb coverage from macOS, but I don't expect this to break very often.

ACKs for top commit:
  fanquake:
    ACK fad2e0a - clearly worthwhile having a sqlite only CI given the amount of bugs this has turned up in the past week or so. Tested running the functional tests with a `--without-bdb` build on macOS and Linux.

Tree-SHA512: d88ad576bbe974a51a2d115e4102fc1bd73772b7393dfa99700fbfd1bdf5deebbf247e35d09757639649a6ad5b193c0998c7db679301a7c012572dfd54a6a289
@bitcoin bitcoin locked and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant