Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear error when pkg-config is not installed #24037

Closed
laanwj opened this issue Jan 11, 2022 · 1 comment · Fixed by #24048
Closed

Unclear error when pkg-config is not installed #24037

laanwj opened this issue Jan 11, 2022 · 1 comment · Fixed by #24048
Labels
Build system Linux/Unix

Comments

@laanwj
Copy link
Member

laanwj commented Jan 11, 2022 •
edited

While running autogen.sh on a newly intalled debian 11.2 system, I got the following error:

libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:16: error: possibly undefined macro: AC_MSG_ERROR
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:261: error: possibly undefined macro: AC_DEFINE
configure.ac:662: error: possibly undefined macro: AC_MSG_WARN
autoreconf: /usr/bin/autoconf failed with exit status: 1

The problem turned out to be that the pkg-config package was missing (autoconf automake libtool were installed). I could not guess this from the error message. It might make sense to add an explicit check to give a more specific error.
@hebasto hebasto mentioned this issue Jan 12, 2022
Merged
@hebasto
Copy link
Member

hebasto commented Jan 12, 2022

Fixed in #24048.

sidhujag pushed a commit to syscoin/syscoin that referenced this issue Jan 13, 2022
@laanwj
Merge bitcoin#24048: build: Improve error message when pkg-config is …
d548ed3 
…not installed

18f304d build: Improve error message when pkg-config is not installed (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#24037.

  With this PR:
  ```
  # ./autogen.sh
  configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
  configure.ac:16: the top level
  autom4te: /usr/bin/m4 failed with exit status: 1
  aclocal: error: /usr/bin/autom4te failed with exit status: 1
  autoreconf: aclocal failed with exit status: 1
  ```

ACKs for top commit:
  laanwj:
    Tested ACK 18f304d
  jarolrod:
    ACK 18f304d

Tree-SHA512: ba845f44c966fea6cf7cee0db9cacc431072e2005ad065c8f2bbe3cffd8415c3af6ed443cccf9606df7de4df2ff3e72636afb5f3776d2a96af8572aab7018549
@bitcoin bitcoin locked and limited conversation to collaborators Jan 13, 2023
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2024
@laanwj @PastaPastaPasta
Merge bitcoin#24048: build: Improve error message when pkg-config is …
513dad1 
…not installed

18f304d build: Improve error message when pkg-config is not installed (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#24037.

  With this PR:
  ```
  # ./autogen.sh
  configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
  configure.ac:16: the top level
  autom4te: /usr/bin/m4 failed with exit status: 1
  aclocal: error: /usr/bin/autom4te failed with exit status: 1
  autoreconf: aclocal failed with exit status: 1
  ```

ACKs for top commit:
  laanwj:
    Tested ACK 18f304d
  jarolrod:
    ACK 18f304d

Tree-SHA512: ba845f44c966fea6cf7cee0db9cacc431072e2005ad065c8f2bbe3cffd8415c3af6ed443cccf9606df7de4df2ff3e72636afb5f3776d2a96af8572aab7018549
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 12, 2024
@laanwj @PastaPastaPasta
Merge bitcoin#24048: build: Improve error message when pkg-config is …
5b9b01b 
…not installed

18f304d build: Improve error message when pkg-config is not installed (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#24037.

  With this PR:
  ```
  # ./autogen.sh
  configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
  configure.ac:16: the top level
  autom4te: /usr/bin/m4 failed with exit status: 1
  aclocal: error: /usr/bin/autom4te failed with exit status: 1
  autoreconf: aclocal failed with exit status: 1
  ```

ACKs for top commit:
  laanwj:
    Tested ACK 18f304d
  jarolrod:
    ACK 18f304d

Tree-SHA512: ba845f44c966fea6cf7cee0db9cacc431072e2005ad065c8f2bbe3cffd8415c3af6ed443cccf9606df7de4df2ff3e72636afb5f3776d2a96af8572aab7018549
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jan 14, 2024
@laanwj @PastaPastaPasta
Merge bitcoin#24048: build: Improve error message when pkg-config is …
187b3c4 
…not installed

18f304d build: Improve error message when pkg-config is not installed (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#24037.

  With this PR:
  ```
  # ./autogen.sh
  configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
  configure.ac:16: the top level
  autom4te: /usr/bin/m4 failed with exit status: 1
  aclocal: error: /usr/bin/autom4te failed with exit status: 1
  autoreconf: aclocal failed with exit status: 1
  ```

ACKs for top commit:
  laanwj:
    Tested ACK 18f304d
  jarolrod:
    ACK 18f304d

Tree-SHA512: ba845f44c966fea6cf7cee0db9cacc431072e2005ad065c8f2bbe3cffd8415c3af6ed443cccf9606df7de4df2ff3e72636afb5f3776d2a96af8572aab7018549
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Build system Linux/Unix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: Improve error message when pkg-config is not installed hebasto/bitcoin
2 participants
@laanwj @hebasto