build: Improve error message when pkg-config is not installed #24048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
reviewed
Jan 12, 2022
There was a problem hiding this comment.
ACK 18f304d
Although the referenced issue is really a case of not reading the docs (@laanwj :D), this is still more helpful than the original message. If anyone ends up in this situation, this will help them get out of it.
Out of the m4 diagnostic messages, diagnostic macros, m4_fatal looks appropriate for this use case.
master: error message without pkg-config installed, running autogen.sh on Debian:
libtoolize: copying file 'build-aux/m4/lt~obsolete.m4'
configure.ac:16: error: possibly undefined macro: AC_MSG_ERROR
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:261: error: possibly undefined macro: AC_DEFINE
configure.ac:662: error: possibly undefined macro: AC_MSG_WARN
autoreconf: /usr/bin/autoconf failed with exit status: 1
pr: error message without pkg-config installed, running autogen.sh on Debian:
configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
configure.ac:16: the top level
|
Tested ACK 18f304d
I agree, but the error message in this case was just absurd. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 13, 2022
…not installed 18f304d build: Improve error message when pkg-config is not installed (Hennadii Stepanov) Pull request description: Fixes bitcoin#24037. With this PR: ``` # ./autogen.sh configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh configure.ac:16: the top level autom4te: /usr/bin/m4 failed with exit status: 1 aclocal: error: /usr/bin/autom4te failed with exit status: 1 autoreconf: aclocal failed with exit status: 1 ``` ACKs for top commit: laanwj: Tested ACK 18f304d jarolrod: ACK 18f304d Tree-SHA512: ba845f44c966fea6cf7cee0db9cacc431072e2005ad065c8f2bbe3cffd8415c3af6ed443cccf9606df7de4df2ff3e72636afb5f3776d2a96af8572aab7018549
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24037.
With this PR: