Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop treating coinbase outputs differently in GUI: show them at 1conf #10221

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
5 participants
@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Apr 17, 2017

Follow-on to the now-merged #10178. Untested.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 17, 2017

utACK 608bbcc

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor Author

TheBlueMatt commented Apr 18, 2017

@sdaftuar went and tested and realized at least I and a few others had a misunderstanding in #10178 - the intended goal of all this logic is to hide orphaned coinbases, but it, as far as I can tell, was always broken in >1 block reorgs (even prior to #10178), and I'm still dubious about having this logic in order to have that behavior - how is a coinbase transaction paying you getting orphaned any different from any other transaction paying you getting conflicted - it seems crazy to hide such transactions entirely because they got orphaned.

@sipa

This comment has been minimized.

Copy link
Member

sipa commented Apr 18, 2017

I assume the original reason (whether it worked or not) was because a reorg will always kill a coinbase payout, while normal transactions (in non-adverserial situations) will just migrate to the new chain.

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor Author

TheBlueMatt commented Apr 18, 2017

@sipa yes, I assume it predated conflicted tagging transactions. Now that we have conflict tracking, I'd still say we should remove it.

@sipa

This comment has been minimized.

Copy link
Member

sipa commented Apr 18, 2017

Concept ACK

@TheBlueMatt Sure, I was just speculating why this logic existed specifically for coinbases and not other transactions.

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Apr 19, 2017

@jonasschnelli jonasschnelli merged commit 608bbcc into bitcoin:master Apr 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Apr 19, 2017

Merge #10221: Stop treating coinbase outputs differently in GUI: show…
… them at 1conf

608bbcc [qt] Stop treating coinbase outputs differently: show them at 1conf (Matt Corallo)

Tree-SHA512: 62ba10520da8b83cf8e97c86dec3ccdcca8b7bfae0174d1a4099d33aa5d11933cc7c248394bf67c2b105211cf7931955816c741957832e703211030c7f4f002f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.