Increase time ago of last block for "up to date" status from 30 to 90 minutes #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minutes It was too hyperactive. gmaxwell: I mean that right now when the block gap goes over an hour it starts showing synchronizing. Increasing that to 90 minutes or so would make it only happen about 6.4 times per year
|
Half an hour was 7 false alarms per day, an hour is a false alarm every three days. Two hours is once per three years. The tradeoff is how quickly you let the user know that something is broken vs false alarms. Since it's already a pretty slow indicator even at 30 minutes, I think we should error towards fewer false alarms. 90 minutes is my recommendation too. |
|
Seems like a good change. |
|
ACK |
gmaxwell
added a commit
that referenced
this pull request
Apr 3, 2012
Increase time ago of last block for "up to date" status from 30 to 90 minutes
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
…te_time Increase time ago of last block for "up to date" status from 30 to 90 minutes
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
sanch0panza
pushed a commit
to sanch0panza/bitcoin
that referenced
this pull request
Apr 11, 2018
Initialize counter to a random value.
laanwj
added a commit
that referenced
this pull request
Jan 15, 2019
fb3ce75 Don't label transactions "Open" while catching up (Hennadii Stepanov) Pull request description: Fix #13299. Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: #1026). This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline. Before this PR (with the issue):  With this PR (the issue has been resolved):  Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
54789ca [Build] missing QWindowStateChangeEvent dependency added. (furszy) af3b0b6 [Cleanup] Cmake, removal of old gui files. (furszy) cf4eeff [Cleanup] Prev 4.0 wallet UI files cleanup. (furszy) Pull request description: Removal and cleanup of the previous wallet UI files (classes and forms) that were still part of the deployment process and not used anywhere. ACKs for top commit: Fuzzbawls: ACK 54789ca Warrows: ACK 54789ca Tree-SHA512: 8db11bcf899772168e412442b78a01bfa840e9e2b5e76e6025dc60d48b81a30fe8a523d6a6c740198a62b3c6bb53134c664bed0aaec757c658163cc1e9d28462
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was too hyperactive.
@gmaxwell: I mean that right now when the block gap goes over an hour it starts showing synchronizing. Increasing that to 90 minutes or so would make it only happen about 6.4 times per year