Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Unit test amount.h/amount.cpp #10280

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Projects
None yet
6 participants
@jimmysong
Copy link
Contributor

commented Apr 26, 2017

Add tests for MoneyRange, binary operators, ToString and a constructor

@fanquake fanquake added the Tests label Apr 26, 2017

src/test/amount_tests.cpp Outdated
BOOST_CHECK(a <= a);
BOOST_CHECK(b >= a);
BOOST_CHECK(b >= b);
// a should now have 2 satoshis/kb

This comment has been minimized.

Copy link
@paveljanik

paveljanik Apr 26, 2017

Contributor

super-micro-nit: let's use our ToString() form here:

// a should be 0.00000002 BTC/kB now
@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2017

Brilliant! Please fix my super-micro-nit and ACK

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

utACK d8a405bd94f0f609602bf55c80cf09f4d57d7d3c

@laanwj

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

utACK

[test] Unit test amount.h/amount.cpp
Add tests for MoneyRange, binary operators, ToString and a constructor

@jimmysong jimmysong force-pushed the jimmysong:test_amount branch to dcb69fd Apr 26, 2017

@jimmysong

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

nit addressed and squashed.

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2017

ACK dcb69fd

247 -> 250 tests. Thank you!

@MarcoFalke MarcoFalke merged commit dcb69fd into bitcoin:master Apr 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Apr 26, 2017

Merge #10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request May 15, 2019

Merge #10280: [test] Unit test amount.h/amount.cpp
Summary:
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

Backport of Core PR10280
bitcoin/bitcoin#10280

Test Plan:
  make check

Reviewers: deadalnix, jasonbcox, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3038

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 12, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

jonspock added a commit to devaultcrypto/devault that referenced this pull request Jun 13, 2019

Merge #10280: [test] Unit test amount.h/amount.cpp
Also fixup feeRate.ToString() output

Summary:
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

Backport of Core PR10280
bitcoin/bitcoin#10280

Test Plan:
  make check

Reviewers: deadalnix, jasonbcox, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3038

jonspock added a commit to jonspock/devault that referenced this pull request Jun 13, 2019

Merge #10280: [test] Unit test amount.h/amount.cpp
Also fixup feeRate.ToString() output

Summary:
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

Backport of Core PR10280
bitcoin/bitcoin#10280

Test Plan:
  make check

Reviewers: deadalnix, jasonbcox, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3038

jonspock added a commit to devaultcrypto/devault that referenced this pull request Jun 13, 2019

Merge #10280: [test] Unit test amount.h/amount.cpp
Also fixup feeRate.ToString() output

Summary:
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

Backport of Core PR10280
bitcoin/bitcoin#10280

Test Plan:
  make check

Reviewers: deadalnix, jasonbcox, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3038

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 14, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 14, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 14, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>

btc -> DASH 10280

Signed-off-by: Pasta <pasta@dashboost.org>

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this pull request Jun 15, 2019

Merge bitcoin#10280: [test] Unit test amount.h/amount.cpp
dcb69fd [test] Unit test amount.h/amount.cpp (Jimmy Song)

Tree-SHA512: dc50e6158322a282a8b8b60c8eab7ce327a33c48113a1455b8a1784f07e6277ad499e85ec978199468a2dc34e9e288287c8803c215f810fa2d841cdda9a414f5

btc to dash

Signed-off-by: Pasta <pasta@dashboost.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.