Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/bitcoin.sh #104

Closed
wants to merge 2 commits into from
Closed

scripts/bitcoin.sh #104

wants to merge 2 commits into from

Conversation

genjix
Copy link

@genjix genjix commented Mar 6, 2011

Intelligent run script. Selects correct architecture (64 bit or 32 bit) and runs the right version of Bitcoin.
Should be placed in the top level dir during release.

See http://www.bitcoin.org/smf/index.php?topic=3904.0

Should be placed in the top level dir during release.
@jgarzik
Copy link
Contributor

jgarzik commented Mar 7, 2011

This seems quite unlike how other Linux apps are distributed, and function.

@tcatm
Copy link

tcatm commented Mar 7, 2011

The script doesn't seem to care about arguments or bitcoind.

@TheBlueMatt
Copy link
Contributor

I agree with jgarzik, though most are distributed as chose a version at download. Should we do that?
In any case you should add $@ to the end of the lines which launch bitcoin to pass arguments.

TheBlueMatt pushed a commit to TheBlueMatt/bitcoin that referenced this pull request Oct 3, 2016
don't increase the re-request interval when we're in regtest
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Dec 9, 2017
  Cherry pick commit b8b969336
  Author:    John Connor <john-connor@users.noreply.github.com>
  Date:      Wed Dec 9 01:02:32 2015 -0500
classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018
Reindex causes segfault (Qtum Core / issue#102)
cryptapus added a commit to cryptapus/bitcoin that referenced this pull request Aug 31, 2018
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Feb 23, 2019
Reverted specification of boost::distance
jonasschnelli added a commit that referenced this pull request Oct 27, 2020
… window without loaded wallets

7b2e42e qt: Add WalletFrame::sizeHint (Hennadii Stepanov)

Pull request description:

  This PR fixes a bug in master (d67883d) and in 0.20.1 that could be easily reproduced with
  ```
  $ src/qt/bitcoin-qt -regtest -resetguisettings -nowallet
  ```

  ![Screenshot from 2020-10-25 21-21-27](https://user-images.githubusercontent.com/32963518/97117179-b1800100-170a-11eb-87c9-3120d39b9455.png)
  ![Screenshot from 2020-10-25 21-23-32](https://user-images.githubusercontent.com/32963518/97117186-b644b500-170a-11eb-8b5d-234ff7205003.png)

  **With this PR:**

  ![Screenshot from 2020-10-25 21-20-35](https://user-images.githubusercontent.com/32963518/97117226-f441d900-170a-11eb-8d66-98b7718a2bb1.png)
  ![Screenshot from 2020-10-25 21-23-03](https://user-images.githubusercontent.com/32963518/97117232-f99f2380-170a-11eb-85ed-c7b5ece926b2.png)

  ---

  Fix #104
  Fix #113

  This PR is an alternative to #107 without [hard-coding a size in pixels](bitcoin-core/gui#107 (comment)).

ACKs for top commit:
  jonasschnelli:
    Tested ACK 7b2e42e - I can confirm this fixes #104 (Ubuntu 20.04 - HiDPI 200%).

Tree-SHA512: eb0692dbeb3befdeecca0e41534c9783eab6637c14cc4f170ee42619235884f9354f8d22a10c20c08cc89dc5340a60b7dfa2523c12e64b3386b3fd2c6d5f934e
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Mar 23, 2021
Refactoring bp::Network into Chain and ChainParams: closes bitcoin#102
cryptapus pushed a commit to cryptapus/bitcoin that referenced this pull request May 3, 2021
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Aug 5, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants