UPnP #113
Closed
UPnP #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Luke Dashjr (luke-jr) for the help with the makefile.
|
Is github broken? The diff/commit looks completely messed up to me... |
|
Oh goddamit, well after today I'm done trying to submit patches. |
glv2
referenced
this pull request
in glv2/peercoin
Sep 7, 2014
translation updates from getlocalization.com/peerunity
dexX7
added a commit
to dexX7/bitcoin
that referenced
this pull request
Jul 7, 2015
ee0bb5a RPC: Categorize calls (zathras-crypto) 3ad578b RPC: Standardize calls on omni_abcdefghij (zathras-crypto)
gavinandresen
pushed a commit
to gavinandresen/bitcoin-git
that referenced
this pull request
Mar 1, 2016
Update README.md link to be relative.
0xartem
referenced
this pull request
in Crowndev/crown-core
Feb 4, 2018
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Feb 23, 2019
Fix accidental reverts from UI merge
jonasschnelli
added a commit
that referenced
this pull request
Oct 27, 2020
… window without loaded wallets 7b2e42e qt: Add WalletFrame::sizeHint (Hennadii Stepanov) Pull request description: This PR fixes a bug in master (d67883d) and in 0.20.1 that could be easily reproduced with ``` $ src/qt/bitcoin-qt -regtest -resetguisettings -nowallet ```   **With this PR:**   --- Fix #104 Fix #113 This PR is an alternative to #107 without [hard-coding a size in pixels](bitcoin-core/gui#107 (comment)). ACKs for top commit: jonasschnelli: Tested ACK 7b2e42e - I can confirm this fixes #104 (Ubuntu 20.04 - HiDPI 200%). Tree-SHA512: eb0692dbeb3befdeecca0e41534c9783eab6637c14cc4f170ee42619235884f9354f8d22a10c20c08cc89dc5340a60b7dfa2523c12e64b3386b3fd2c6d5f934e
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally a seemingly proper patch for UPnP Port Mapping.
Note that this one still does not have proper support in the makefiles for anything but UNIX.