Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: Update laanwj key #10688

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Jun 28, 2017

I recently added a signing subkey (0x1E4AED62986CD25D), which is used to sign gitian asserts as well as commits.

Old:

pub  rsa2048/0x74810B012346C9A6 2011-08-24
uid                             Wladimir J. van der Laan <laanwj@gmail.com>
sub  rsa2048/0xF69705ED890DE427 2011-08-24

New:

pub  rsa2048/0x74810B012346C9A6 2011-08-24 [expires: 2019-02-14]
uid                             Wladimir J. van der Laan <laanwj@visucore.com>
uid                             Wladimir J. van der Laan <laanwj@gmail.com>
sub  rsa2048/0xF69705ED890DE427 2011-08-24
sub  rsa2048/0x1E4AED62986CD25D 2017-05-17 [expires: 2019-05-17]
sub  rsa2048/0x69B4C4CDC628F8F9 2017-05-17 [expires: 2019-05-17]

Not sure this warrants an update in the repository, but as it is more than just updating expiration dates, it might (its still within the reach of --refresh-keys though).

I recently added a signing subkey, which is used to sign gitian
asserts as well as commits.

Old:
```
pub  rsa2048/0x74810B012346C9A6 2011-08-24
uid                             Wladimir J. van der Laan <laanwj@gmail.com>
sub  rsa2048/0xF69705ED890DE427 2011-08-24
```

New:
```
pub  rsa2048/0x74810B012346C9A6 2011-08-24 [expires: 2019-02-14]
uid                             Wladimir J. van der Laan <laanwj@visucore.com>
uid                             Wladimir J. van der Laan <laanwj@gmail.com>
sub  rsa2048/0xF69705ED890DE427 2011-08-24
sub  rsa2048/0x1E4AED62986CD25D 2017-05-17 [expires: 2019-05-17]
sub  rsa2048/0x69B4C4CDC628F8F9 2017-05-17 [expires: 2019-05-17]
```
@jonasschnelli
Copy link
Contributor

tested ACK

# off=16266 ctb=b9 tag=14 hlen=3 plen=269
:public sub key packet:
	version 4, algo 1, created 1495035661, expires 0
	pkey[0]: [2048 bits]
	pkey[1]: [17 bits]
	keyid: 1E4AED62986CD25D

Commit is signed with 1E4AED62986CD25D.
Ideally, you sign this PR's description with your current known key, but since it's a subkey, that doesn't really matter.

Curios why you did chose 2048 bits and not 4098?
Encrypt II as well as BSI recommendation (as of >2022) are in the 3000+ range...

@laanwj
Copy link
Member Author

laanwj commented Jun 28, 2017

Curios why you did chose 2048 bits and not 4098?
Encrypt II as well as BSI recommendation (as of >2022) are in the 3000+ range...

Wouldn't that just be security theater though, as the master key is 2048 bits?
Could create another subkey but I don't think it will make things any less confusing.

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jun 28, 2017

Wouldn't that just be security theater though, as the master key is 2048 bits?

Oh yes. Your right... haven't looked at the master keys bits.

@fanquake
Copy link
Member

ACK 3c85332

@maflcko
Copy link
Member

maflcko commented Jun 29, 2017

utACK 3c85332. It is the key I already have:

gpg --import < contrib/gitian-keys/laanwj-key.pgp
gpg: key 2346C9A6: "Wladimir J. van der Laan <laanwj@visucore.com>" not changed

Going to merge this, but we should really just add a script to update all keys in that folder.

@maflcko maflcko merged commit 3c85332 into bitcoin:master Jun 29, 2017
maflcko pushed a commit that referenced this pull request Jun 29, 2017
3c85332 contrib: Update laanwj key (Wladimir J. van der Laan)

Tree-SHA512: c8cad76158850a3e480ccb58ee86c3dbb4e45ef67376173720c2520d3cb02c1c3e13b4e0acea3be6d90991e073db49aad2e185a87a09be194f1d1605b31b6ee4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants