Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Move script flag to/from-string logic from tests to script/interpreter #10730
+1,213
−1,197
Conversation
fanquake
added
the
Validation
label
Jul 3, 2017
|
Needs rebase |
luke-jr
added some commits
Jul 2, 2017
|
Rebased |
|
I'm okay with moving this out of the tests if it's necessary in another place, however the from/to string stuff doesn't belong with the interpreter consensus code IMO. Better to keep it in a separate compilation unit, like with the CBitcoinAddress split done in #11117. |
|
@luke-jr ping? |
|
Hmm, so where would you suggest? Bundle it in with RPC-specific stuff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
luke-jr commentedJul 3, 2017
When we last discussed making scripts debuggable (sometime after #3901), the plan was to instead trace execution rather than single-step through it.
This is a dependency step toward that, and is eventually used for the RPC
verifyscriptto parse its"flags"option.See also #10729