New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move script flag to/from-string logic from tests to script/interpreter #10730

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@luke-jr
Member

luke-jr commented Jul 3, 2017

When we last discussed making scripts debuggable (sometime after #3901), the plan was to instead trace execution rather than single-step through it.

This is a dependency step toward that, and is eventually used for the RPC verifyscript to parse its "flags" option.

See also #10729

@fanquake fanquake added the Validation label Jul 3, 2017

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 13, 2017

Member

Needs rebase

Member

jonasschnelli commented Jul 13, 2017

Needs rebase

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Sep 2, 2017

Member

Rebased

Member

luke-jr commented Sep 2, 2017

Rebased

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Sep 6, 2017

Member

I'm okay with moving this out of the tests if it's necessary in another place, however the from/to string stuff doesn't belong with the interpreter consensus code IMO. Better to keep it in a separate compilation unit, like with the CBitcoinAddress split done in #11117.

Member

laanwj commented Sep 6, 2017

I'm okay with moving this out of the tests if it's necessary in another place, however the from/to string stuff doesn't belong with the interpreter consensus code IMO. Better to keep it in a separate compilation unit, like with the CBitcoinAddress split done in #11117.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj
Member

laanwj commented Nov 20, 2017

@luke-jr ping?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Nov 20, 2017

Member

Hmm, so where would you suggest? Bundle it in with RPC-specific stuff?

Member

luke-jr commented Nov 20, 2017

Hmm, so where would you suggest? Bundle it in with RPC-specific stuff?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Apr 1, 2018

Member

Rebased, and moved it to script/script_flags.{h,cpp} for now.

Member

luke-jr commented Apr 1, 2018

Rebased, and moved it to script/script_flags.{h,cpp} for now.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jun 16, 2018

Member

Closing due to apparent lack of interest/reviewers

Member

luke-jr commented Jun 16, 2018

Closing due to apparent lack of interest/reviewers

@luke-jr luke-jr closed this Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment