Move script flag to/from-string logic from tests to script/interpreter #10730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase |
luke-jr
force-pushed
the
scriptflag_strings
branch
from
6a97f59
to
97cae39
Compare
|
Rebased |
|
I'm okay with moving this out of the tests if it's necessary in another place, however the from/to string stuff doesn't belong with the interpreter consensus code IMO. Better to keep it in a separate compilation unit, like with the CBitcoinAddress split done in #11117. |
|
@luke-jr ping? |
|
Hmm, so where would you suggest? Bundle it in with RPC-specific stuff? |
P2SH is a general term, and can be applied to Segwit program v0 of 32 bytes too
luke-jr
force-pushed
the
scriptflag_strings
branch
from
97cae39
to
e2e183b
Compare
|
Rebased, and moved it to script/script_flags.{h,cpp} for now. |
|
Closing due to apparent lack of interest/reviewers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we last discussed making scripts debuggable (sometime after #3901), the plan was to instead trace execution rather than single-step through it.
This is a dependency step toward that, and is eventually used for the RPC
verifyscriptto parse its"flags"option.See also #10729