Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 #10825
+17
−3
Conversation
fametrano
added some commits
Jul 14, 2017
fametrano
changed the title from
Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 to NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332
Jul 14, 2017
fanquake
added the
P2P
label
Jul 15, 2017
laanwj
added the
Tests
label
Jul 17, 2017
|
Concept ACK. I never understood why testnet and regtest should overlap resources. |
|
Concept ACK |
|
Dont think its worth updating tor.md (as regtest nodes shouldn't really be connecting to each other/exposed publicly), but otherwise looks good! |
|
After fixing the nit, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fametrano commentedJul 14, 2017
•
edited
using the same JSON-RPC default port for both testnet and regtest prevents running both at the same time on the same machine. Since RPCport=P2Pport-1 for both mainnet and testnet, and regtest P2Pport being 18444, 18443 is proposed for regtest RPCport
Documentation has been updated (or created where missing); manpages doc/man/bitcoin*.1 could include information for regtest too