Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 #10825

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
6 participants
@fametrano
Copy link
Contributor

commented Jul 14, 2017

using the same JSON-RPC default port for both testnet and regtest prevents running both at the same time on the same machine. Since RPCport=P2Pport-1 for both mainnet and testnet, and regtest P2Pport being 18444, 18443 is proposed for regtest RPCport

Documentation has been updated (or created where missing); manpages doc/man/bitcoin*.1 could include information for regtest too

@fametrano fametrano changed the title Net set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 Jul 14, 2017

@fanquake fanquake added the P2P label Jul 15, 2017

@laanwj laanwj added the Tests label Jul 17, 2017

@laanwj

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

Concept ACK. I never understood why testnet and regtest should overlap resources.

@sipa

This comment has been minimized.

Copy link
Member

commented Jul 25, 2017

Concept ACK

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

Dont think its worth updating tor.md (as regtest nodes shouldn't really be connecting to each other/exposed publicly), but otherwise looks good!

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

After fixing the nit, please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@fametrano fametrano force-pushed the fametrano:fametrano-regtestport branch Aug 4, 2017

@fametrano fametrano force-pushed the fametrano:fametrano-regtestport branch to ce3baa1 Aug 4, 2017

@fametrano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

removed tor.md change, squashed the rest

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 5, 2017

utACK ce3baa1

@laanwj laanwj changed the title NET: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 net: set regtest JSON-RPC port to 18443 to avoid conflict with testnet 18332 Sep 5, 2017

@laanwj laanwj merged commit ce3baa1 into bitcoin:master Sep 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 5, 2017

Merge #10825: net: set regtest JSON-RPC port to 18443 to avoid confli…
…ct with testnet 18332

ce3baa1 changed regtest RPCport to 18443 to avoid conflict with testnet 18332 (Ferdinando M. Ametrano)

Pull request description:

  using the same JSON-RPC default port for both testnet and regtest prevents running both at the same time on the same machine. Since RPCport=P2Pport-1 for both mainnet and testnet, and regtest P2Pport being 18444, 18443 is proposed for regtest RPCport

  Documentation has been updated (or created where missing); manpages doc/man/bitcoin*.1 could include information for regtest too

Tree-SHA512: d42185f7ef54dc918ece19b543c8681d08bb9c5a971394e21f2d9a1091734b091b08df69fab622c207b46f402cf9323ded5b7a33fbd0af722388930169124e7f

nopara73 added a commit to nopara73/NBitcoin that referenced this pull request Feb 27, 2018

[Skip CI] [WIP] Set regtest JSON-RPC port to 18443 to avoid conflict …
…with testnet 18332.

Bitcoin Core changed the default RegTest port: bitcoin/bitcoin#10825

I'm making this PR according to issue: MetacoSA#348 (comment)

Why it's WIP, because I'm still looking for how to update your `bitcoind` version using for tests.

ariard added a commit to ariard/bitcoin that referenced this pull request Aug 23, 2018

Add new regtest ports in doc following bitcoin#10825 ports reattribut…
…ions

Add checkmempool and checkblockindex regtest true in doc

laanwj added a commit that referenced this pull request Sep 4, 2018

Merge #14013: [doc] Add new regtest ports in man following #10825 por…
…ts reattributions

e8c4a1e Add new regtest ports in doc following #10825 ports reattributions (Antoine Riard)

Pull request description:

  Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3

HashUnlimited added a commit to ToDoThings/bitcoin that referenced this pull request Sep 10, 2018

Add new regtest ports in doc following bitcoin#10825 ports reattribut…
…ions

Add checkmempool and checkblockindex regtest true in doc

jfhk added a commit to jfhk/bitcoin that referenced this pull request Nov 14, 2018

Add new regtest ports in doc following bitcoin#10825 ports reattribut…
…ions

Add checkmempool and checkblockindex regtest true in doc

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Nov 26, 2018

Add new regtest ports in doc following bitcoin#10825 ports reattribut…
…ions

Add checkmempool and checkblockindex regtest true in doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.