Update translations for bitcoin core #1089
Conversation
|
Im fine with wthis change in general (ACK). If it get's merged #1000 (yay ^^) can be closed, too! |
|
I'll re-run with -no-obsolete and change Hide to lowercase. I don't have control over which plural forms are generated. |
|
Great! I'm very sure the plural forms (english base) need to be put in the .ts Am 13.04.2012 15:03, schrieb Wladimir J. van der Laan:
|
|
Can you point to the documentation on that? It sounds unlikely; TS files are supposed to be generated automatically from the source code. |
|
Look at the other plurals or numerusform tags in the en .ts file. I'm sure someone placed the translations for the existing numerusform tags in there. It seems this can be done with Qt Linguist application (open the en .ts and search for %n second(s) ago in BitcoinGUI), as the existing translations where plural forms are used are displayed with a yellow question mark and the english translation text IS filled in for them, right? A doc is here, but I'm not sure if that's mentioned: |
|
It seems Qt Linguist is the tool of choice :) ... you can even say that a translation is finished, which marks the string with a green check + removes the type="unfinished" tag for finished translations (that's for english master file - translation here means you looked through, added plural forms and marked strings as finished), cool! |
|
Ok, you're right. I misunderstood. The _en needs to be manually updated to make the plural mechanism work in English, not to facilitate translations. https://qt-project.org/doc/qt-4.8/linguist-programmers.html (under "Handling Plural Forms") |
|
Fixed; and also marked the plural forms as "finished". |
|
Looks pretty good, so ACK! |
|
@laanwj 1 more thing I observed while playing around in Qt Linguist, we should set the base language of our en .ts file to only english (currently set to country USA). This can be done under Edit -> Translation File Settings...: |
- Move scripts/qt to share/qt, to clean up toplevel directories - Update english ts file which is used to source messages for Transifex - In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed
|
Ok, fixed too... |
Update translations for bitcoin core
Update translations for bitcoin core
* PS: should check for prevout to match inputs * fix CDarkSendEntry constructor
* Set the minining max block size in excessiveblock_test.cpp This makes sure we're starting at the right miningsize in case it was somehow set to a different value in a previous test. * fix transaction_tests.cpp assigne the value of 83 to maxdatacarrierbytes in case it was changed prior to running this set of tests. * Fix excessive.py so that it works after the may15th fork * fix mempool_reorg.py to work after fork activation. * Fix the may152018_forkactivation_2.py Since the fork time has passed we need to explicity set the pre fork time when we mined the first set of blocks. * small fix for mempool_reorg
This will not break any current translations, but will allow new messages to be translated.