Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: bitcoinstrings.cpp needs update #1000

Closed
Diapolo opened this issue Mar 28, 2012 · 4 comments
Closed

translation: bitcoinstrings.cpp needs update #1000

Diapolo opened this issue Mar 28, 2012 · 4 comments
Assignees

Comments

@Diapolo
Copy link

Diapolo commented Mar 28, 2012

The file seems to be created by a script called extract_strings.py and is missing several strings from new or modified command line switches. This needs to be updated, to be able to create a full translation of the client. It seems like @laanwj did this the last time.

I would suggest, that there will be defined a standard as to when this file gets updated. At least the final RCs of a new version should include a complete translation and this takes some time for the translators, so the english source files need to be pushed to transifex early (the latest, if a new version is feature-complete). I as a native german speaking person think it's a great benefit for all Client users, if it's completely presented in the native language, so that should get some more love.

@ghost ghost assigned tcatm Mar 28, 2012
@laanwj
Copy link
Member

laanwj commented Mar 31, 2012

Agreed.

And congrats on issue #1000 :-)

@Diapolo
Copy link
Author

Diapolo commented Mar 31, 2012

Cool, where is my price :-D?

@laanwj
Copy link
Member

laanwj commented Apr 14, 2012

Ok, messages updated, it will just have to be pushed to transifex...

@Diapolo
Copy link
Author

Diapolo commented Apr 21, 2012

As the en master file get's fetched from Transifex if updated and this happened a few days ago, I close this one and start translating the german parts ;).

@Diapolo Diapolo closed this as completed Apr 21, 2012
lateminer pushed a commit to lateminer/bitcoin that referenced this issue Oct 30, 2019
84930b9 [Trivial] Align the format of the log messages in kernel.cpp (random-zebra)
faa9090 [Trivial] rename DisconnectBlocks argument for consistency (random-zebra)
3df34c6 [Spork] fix CSporkManager maps (random-zebra)
3ec2f61 [Tests] spork functional test: check spork value after node restart (random-zebra)
8f6d6e1 [Core] ReprocessBlocks: adjust to PIVX blocktime (random-zebra)
50bfe70 Fix spork RPC to use new spork defs (random-zebra)
fd05256 [Spork] Make CSporkMessage::vchSig private (random-zebra)
3709ba8 [Spork] Introduce CSporkDef and remove if/else blocks (random-zebra)
4df1046 [Spork] Define SporkId enum (with its serialization) (random-zebra)
41effbf [Spork] Remove unused SPORK_11 and SPORK_12 (random-zebra)
459e41a [Spork] Remove unused SPORK_7_MASTERNODE_SCANNING (random-zebra)
5124b89 [Spork] Do not accept sporks signed too far into the future (random-zebra)
806f607 [Spork] CSporkManager class serialization (random-zebra)
cd33d3c [Spork] Protect CSporkManager with critical section (random-zebra)
c41dd7c [Refactor] refactor/fix CSporkManager and CSporkMessage classes (random-zebra)
ab603a1 [Refactor] rename SporkKey to SporkPubKey (random-zebra)

Pull request description:

  Chengeset:

  - move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager
  - move Sign, CheckSignature, Relay to CSporkMessage
  - move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks
  - rename SporkKey to SporkPubKey
  - bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully
  - few log format changes, cleaned up includes
  - Protect CSporkManager with critical section
  - bugfix:  do not accept sporks with nTimeSigned way too far into the future
  - remove unused sporks: 7, 11, 12
  - Refactor code to get rid of repeated if/else blocks (introduce CSporkDef)

  Mostly based off of:
  - dashpay#922
  - dashpay#2213
  - dashpay#2578
  - dashpay#2607
  - dashpay#2946

ACKs for top commit:
  Warrows:
    ACK 84930b9
  furszy:
    ACK [`84930b9`](PIVX-Project@84930b9)

Tree-SHA512: 17f923e85371c444aa2092b12b025db1894c55679549d1a6a3d9f4525f8d78e9225d3f05e296643e7c79d02414bef1613f14d441901dc5f52531c3f30dce357c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants