Fixing offscreen GUI issue #11208

meshcollider · 2017-08-31T20:18:58Z

Fixes #11207

This still obviously needs to be confirmed as the cause of the issues in question, this is the current assumption

Edit: c.f. #11335

maflcko · 2017-08-31T20:28:14Z

Tagged for backport in case there will be another rc

jtimon · 2017-08-31T21:27:54Z

utACK 7765030

promag

Concept ACK.

promag · 2017-08-31T21:52:48Z

src/qt/guiutil.cpp

-        QRect screen = QApplication::desktop()->screenGeometry();
+
+    QRect screen = QApplication::desktop()->screenGeometry();
+    if ((!pos.x() && !pos.y()) || pos.x() > screen.width() || pos.y() > screen.height() || (QApplication::desktop()->screenNumber(parent) == -1)) {


How about

if (!screen.contains(parent->geometry()) || QApplication::desktop()->screenNumber(parent) == -1) {

And I think the first condition is enough, not sure though.

parent->geometry() does not include the window frame, so perhaps frameGeometry()? But yeah I guess a check for full containment makes sense rather than just the point pos()

promag · 2017-08-31T22:02:59Z

src/qt/guiutil.cpp

-    {
-        QRect screen = QApplication::desktop()->screenGeometry();
+
+    QRect screen = QApplication::desktop()->screenGeometry();


Use availableGeometry().

Yep sounds good. I'll fix it to availableGeometry(screen_number) too now that I think about it. Will push it as a separate commit for review before squashing.

achow101 · 2017-08-31T23:17:56Z

ACK 7765030

Tested on Windows 10, confirms that this fixes the issue I identified in #11207. However #11171 sounds like it is a different problem.

AllanDoensen · 2017-09-01T11:00:45Z

I believe this was fixed here : #10156

promag · 2017-09-01T11:10:52Z

src/qt/guiutil.cpp

-    if ((!pos.x() && !pos.y()) || (QApplication::desktop()->screenNumber(parent) == -1))
-    {
-        QRect screen = QApplication::desktop()->screenGeometry();
+


Remove whitespace.

promag · 2017-09-01T11:18:40Z

src/qt/guiutil.cpp

+    
+    int screen_number = QApplication::desktop()->screenNumber(parent);
+    QRect screen = QApplication::desktop()->availableGeometry(screen_number);
+    if ((!pos.x() && !pos.y()) || screen_number == -1 || !screen.contains(parent->frameGeometry())) {


If I understand correctly, !pos.x() && !pos.y() should be replaced with !settings.contains(strSettings + "Pos").

Safer to check after converting it to a point, just to make sure conversion worked properly?

But what if the window position is QPoint(0, 0)?

promag · 2017-09-01T11:21:39Z

src/qt/guiutil.cpp

-        QRect screen = QApplication::desktop()->screenGeometry();
+
+    int screen_number = QApplication::desktop()->screenNumber(parent);
+    QRect screen = QApplication::desktop()->availableGeometry(screen_number);


What if the result of availableGeometry() when screen_number = -1?

Do you mean -1? If the parameter is -1, it returns the default screen

Fixed above comment.

luke-jr

utACK

Github-Pull: bitcoin#11208 Rebased-From: 7765030

Github-Pull: bitcoin#11208 Rebased-From: 6067244

jonasschnelli · 2017-09-03T17:27:30Z

src/qt/guiutil.cpp

-        QRect screen = QApplication::desktop()->screenGeometry();
+    int screen_number = QApplication::desktop()->screenNumber(parent);
+    QRect screen = QApplication::desktop()->availableGeometry(screen_number);
+    if ((!pos.x() && !pos.y()) || screen_number == -1 || !screen.contains(parent->frameGeometry())) {


Does this allow a window that is halfway moved out of the screen (I think we should allow this)?

No I don't think it does, but I thought about that and the expected behaviour of most software is that it launches within the screen even if you moved it partially out last time?

sipa · 2017-09-03T21:08:11Z

utACK

laanwj · 2017-09-05T15:56:44Z

I believe this was fixed here : #10156

I was about to remark this - there have been a few PRs before in the last few years 'fixing' this issue, but it keeps returning (or wasn't fixed properly after all). So normally we would make sure of this by unit tests but I don't think that's an option here due to the GUI-ness. So I suggest creating a manual testplan before/after, so we can verify that this bug is squashed.

jonasschnelli · 2017-09-05T21:19:22Z

Just tested on macOS and windows 8.1 (VM):
Current master OSX: if I move the window outside of the boundary, it will relocate the window to the maximum boundaries without overlapping the visible area.
With this PR OX: overlapping the boundaries will always lead to reopen it in the screen center.
(I think this is acceptable, but slightly different to the current state).

Could not reproduce the issue on Windows 8.1 (did run on a very large screen, closes Bitcoin-Qt while having the main window on the right bottom, reduce screen by times 4, re-started Qt and had the window visible)

laanwj · 2017-09-06T17:32:48Z

So it's unclear whether this is actually needed. Removing the milestone.

laanwj · 2017-09-15T08:44:23Z

Closing in favor of #11335

13baf72 Replace save|restoreWindowGeometry with Qt functions (MeshCollider) Pull request description: Alternative to #11208, closes #11207 According to the [Qt documentation](https://doc.qt.io/qt-4.8/qwidget.html#restoreGeometry), restoreGeometry does all the checks we need, so it would be better to rely on them instead of doing it ourselves. ~Haven't tested this properly yet, hence the WIP.~ Gives expected behavior exactly as the other system apps do based on my tests. Only potential issue is the case when the GUI is almost entirely offscreen with only a single strip of pixels, its not really possible to see the GUI, but if you know it's there you can bring it back onscreen with just the mouse. And that's exactly how notepad behaves on Windows so I don't think its a real issue. This also gives much better behavior when closing a maximized window, currently (0.15.0 release) a maximized window will save the window size on close, and then reopen as a not-maximized but still that size, which is really annoying. This reopens as maximized. Gitian build here: https://bitcoin.jonasschnelli.ch/build/305 Tree-SHA512: a8bde14793b4316192df1fa2eaaeb32b44d5ebc5219c35252379840056cd737a9fd162625fd715987f275fec8375334ec1ec328dbc671563f084c611a938985c

…ions 13baf72 Replace save|restoreWindowGeometry with Qt functions (MeshCollider) Pull request description: Alternative to bitcoin#11208, closes bitcoin#11207 According to the [Qt documentation](https://doc.qt.io/qt-4.8/qwidget.html#restoreGeometry), restoreGeometry does all the checks we need, so it would be better to rely on them instead of doing it ourselves. ~Haven't tested this properly yet, hence the WIP.~ Gives expected behavior exactly as the other system apps do based on my tests. Only potential issue is the case when the GUI is almost entirely offscreen with only a single strip of pixels, its not really possible to see the GUI, but if you know it's there you can bring it back onscreen with just the mouse. And that's exactly how notepad behaves on Windows so I don't think its a real issue. This also gives much better behavior when closing a maximized window, currently (0.15.0 release) a maximized window will save the window size on close, and then reopen as a not-maximized but still that size, which is really annoying. This reopens as maximized. Gitian build here: https://bitcoin.jonasschnelli.ch/build/305 Tree-SHA512: a8bde14793b4316192df1fa2eaaeb32b44d5ebc5219c35252379840056cd737a9fd162625fd715987f275fec8375334ec1ec328dbc671563f084c611a938985c

13baf72 Replace save|restoreWindowGeometry with Qt functions (MeshCollider) Pull request description: Alternative to bitcoin/bitcoin#11208, closes bitcoin/bitcoin#11207 According to the [Qt documentation](https://doc.qt.io/qt-4.8/qwidget.html#restoreGeometry), restoreGeometry does all the checks we need, so it would be better to rely on them instead of doing it ourselves. ~Haven't tested this properly yet, hence the WIP.~ Gives expected behavior exactly as the other system apps do based on my tests. Only potential issue is the case when the GUI is almost entirely offscreen with only a single strip of pixels, its not really possible to see the GUI, but if you know it's there you can bring it back onscreen with just the mouse. And that's exactly how notepad behaves on Windows so I don't think its a real issue. This also gives much better behavior when closing a maximized window, currently (0.15.0 release) a maximized window will save the window size on close, and then reopen as a not-maximized but still that size, which is really annoying. This reopens as maximized. Gitian build here: https://bitcoin.jonasschnelli.ch/build/305 Tree-SHA512: a8bde14793b4316192df1fa2eaaeb32b44d5ebc5219c35252379840056cd737a9fd162625fd715987f275fec8375334ec1ec328dbc671563f084c611a938985c

…ions 13baf72 Replace save|restoreWindowGeometry with Qt functions (MeshCollider) Pull request description: Alternative to bitcoin#11208, closes bitcoin#11207 According to the [Qt documentation](https://doc.qt.io/qt-4.8/qwidget.html#restoreGeometry), restoreGeometry does all the checks we need, so it would be better to rely on them instead of doing it ourselves. ~Haven't tested this properly yet, hence the WIP.~ Gives expected behavior exactly as the other system apps do based on my tests. Only potential issue is the case when the GUI is almost entirely offscreen with only a single strip of pixels, its not really possible to see the GUI, but if you know it's there you can bring it back onscreen with just the mouse. And that's exactly how notepad behaves on Windows so I don't think its a real issue. This also gives much better behavior when closing a maximized window, currently (0.15.0 release) a maximized window will save the window size on close, and then reopen as a not-maximized but still that size, which is really annoying. This reopens as maximized. Gitian build here: https://bitcoin.jonasschnelli.ch/build/305 Tree-SHA512: a8bde14793b4316192df1fa2eaaeb32b44d5ebc5219c35252379840056cd737a9fd162625fd715987f275fec8375334ec1ec328dbc671563f084c611a938985c

Fixing offscreen GUI issue

7765030

maflcko added the GUI label Aug 31, 2017

maflcko added this to the 0.15.0 milestone Aug 31, 2017

maflcko added the Needs backport label Aug 31, 2017

promag reviewed Aug 31, 2017

View reviewed changes

achow101 mentioned this pull request Aug 31, 2017

[Windows] GUI window can still appear off screen. #11207

Closed

promag reviewed Sep 1, 2017

View reviewed changes

Check screen contains window when restoring geometry

6067244

luke-jr approved these changes Sep 2, 2017

View reviewed changes

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Sep 2, 2017

Fixing offscreen GUI issue

80b0f37

Github-Pull: bitcoin#11208 Rebased-From: 7765030

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Sep 2, 2017

Check screen contains window when restoring geometry

347a7ef

Github-Pull: bitcoin#11208 Rebased-From: 6067244

jonasschnelli reviewed Sep 3, 2017

View reviewed changes

maflcko modified the milestones: 0.15.1, 0.15.0 Sep 5, 2017

jonasschnelli mentioned this pull request Sep 5, 2017

[0.15] Mention offscreen issue in release notes #11245

Closed

laanwj removed the Needs backport label Sep 6, 2017

laanwj removed this from the 0.15.1 milestone Sep 6, 2017

meshcollider mentioned this pull request Sep 15, 2017

Replace save|restoreWindowGeometry with Qt functions #11335

Merged

laanwj closed this Sep 15, 2017

meshcollider deleted the 201709_offscreen_fix branch October 13, 2017 21:28

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing offscreen GUI issue #11208

Fixing offscreen GUI issue #11208

meshcollider commented Aug 31, 2017 •

edited

Loading

maflcko commented Aug 31, 2017

jtimon commented Aug 31, 2017

promag left a comment

promag Aug 31, 2017

meshcollider Sep 1, 2017

promag Aug 31, 2017

meshcollider Sep 1, 2017

achow101 commented Aug 31, 2017

AllanDoensen commented Sep 1, 2017

promag Sep 1, 2017

promag Sep 1, 2017

meshcollider Sep 1, 2017

promag Sep 1, 2017

promag Sep 1, 2017 •

edited

Loading

meshcollider Sep 1, 2017

promag Sep 1, 2017

luke-jr left a comment

jonasschnelli Sep 3, 2017

meshcollider Sep 3, 2017

sipa commented Sep 3, 2017

laanwj commented Sep 5, 2017

jonasschnelli commented Sep 5, 2017

laanwj commented Sep 6, 2017

laanwj commented Sep 15, 2017

Fixing offscreen GUI issue #11208

Fixing offscreen GUI issue #11208

Conversation

meshcollider commented Aug 31, 2017 • edited Loading

maflcko commented Aug 31, 2017

jtimon commented Aug 31, 2017

promag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

achow101 commented Aug 31, 2017

AllanDoensen commented Sep 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag Sep 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luke-jr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sipa commented Sep 3, 2017

laanwj commented Sep 5, 2017

jonasschnelli commented Sep 5, 2017

laanwj commented Sep 6, 2017

laanwj commented Sep 15, 2017

meshcollider commented Aug 31, 2017 •

edited

Loading

promag Sep 1, 2017 •

edited

Loading