Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code #1178
Conversation
|
Sure, will report back after I did the tests :). |
| @@ -17,6 +18,9 @@ | |||
| #include <QDesktopServices> | |||
| #include <QThread> | |||
|
|
|||
| #include <boost/filesystem.hpp> | |||
| #include <boost/filesystem/fstream.hpp> | |||
|
|
|||
There was a problem hiding this comment.
This needs:
#ifdef WIN32
#include "shlwapi.h"
#endif
|
Seems like a good idea to move MyGetSpecialFolderPath function from util.cpp into guiutil.cpp, too, as I currently get: guiutil.cpp:229: Fehler:'MyGetSpecialFolderPath' was not declared in this scope. |
|
It seems that shlwapi.h can be removed from util.cpp after your changes. |
|
Thanks for the fixes. MyGetSpecialFolderPath cannot be moved as it's also used in GetDefaultDataDir, which should certainly stay in the core code. On the other hand, if we can remove the fallbacks, we could simply use the windows API function SHGetSpecialFolderPathA directly in both places and get rid of MyGetSpecialFolderPath. For now, I'll simply add it to util.h. |
|
Ok, updated. |
|
Now compiles fine on Windows, just see above comment for guiutil.cpp :). I will have to rebase #1134 after this get's merged, but that's fine. I consider removing MyGetSpecialFolderPath() then. |
|
Updated to _WIN32_IE 0x0501 |
|
Rebased |
Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code
…mstartup Move GetStartOnSystemStartup and SetStartOnSystemStartup to GUI code
Initialize BIP16Height to 0 for nol net
…ve addresses list. 6ee4e57 [GUI][Bug] cold staking screen, fixing show receive addresses list in owner address editLine. (furszy) Pull request description: It was invalidly blocking the launch of the dropdown menu for a bad check. Instead of the receive addresses (`sizeRecv()`), was checking against the stored contacts in the address book (`sizeSend()`) . ACKs for top commit: Fuzzbawls: utACK 6ee4e57 random-zebra: utACK 6ee4e57 and merging... Tree-SHA512: 3a4bf346079e35baaf5f66379e303cdfdffef662c099c967f421cc309f82b514bde4c716ad5df5c669164b82d533663ebf11d9af75b468143f6d52b802854da9
Add new transaction type to embed any data
...as this is the logical place for them.
@Diapolo can you test whether this still builds on windows? I'm not sure what includes are needed for CoCreateInstance / GetModuleFileName.