fix for #952 (send coins tab glitch) #1189
Conversation
|
Can you please move the checking logic to WalletModel instead of inside SetAddressBookName? That'd make it an UI-only change and much easier to test. |
|
The question is, if walletmodel.cpp is the only place, where that check makes senes or if it's beneficial to all places in the source? I'm fine if it's only needed in walletmodel.cpp, so can you verify this? |
| return false; | ||
| return CWalletDB(strWalletFile).WriteName(address.ToString(), strName); | ||
| std::map<CBitcoinAddress, std::string>::iterator mi = mapAddressBook.find(address); | ||
| // Check if we have a new address or label |
There was a problem hiding this comment.
// Check if we have a new address or updated label
|
Well, it'd be nice to only change only the UI for an UI-only fix. Then again, I guess the extra check doesn't hurt (except that it complicates the code a bit). |
|
@laanwj Updated to be a GUI-fix only, is the LOCK in parentheses correct? I get now compiler warning, just want to be sure :) |
|
The LOCK is not correct. You need to have the lock before any access to the address book, so also while doing the check. |
|
Alright, the LOCK is now before any access to wallet, locking good now? |
|
Yes, it's ok now |
fix for #952 (send coins tab glitch)
fix for #952 (send coins tab glitch)
…itcoin#1189) At the same times actually log the coin freeze avaiblity from the then branch of the if statement that checks that the utxo is spendable.
d0b3494 [GUI] Feature/Bug CoinControl Update on Open (Liquid369) Pull request description: Improvement on bitcoin#1189 Tested working ACKs for top commit: furszy: ACK d0b3494 random-zebra: utACK d0b3494 and merging... Tree-SHA512: 5e8165df2e9eca41a79b971483438b0d4435f5101a1667e900380b0c365b795481fa38fe28389b7dfebe29f1475ed1b4c84f9c5802013f6f13783440679c6892
Tested on testnet and works as expected (fixes #952), if I send coins and update or set a label for an address it get's updated in the address list, which it did not before.