[tests] util_tests.cpp: actually check ignored args

[ajtowns]

An array with 7 elements was setup for checking argument parsing, but
was passed to ParseParamaeters with argc=5, meaning the interpretation
of the last two arguments was never actually checked.

[promag]

utACK 4e196a9.

[promag]

IMO remove this assert.

[ajtowns]

The assert doesn't have any runtime cost, and documents/enforces the change as well as helping avoid the same mistake happening again, so seems better to have it to me?

An alternative approach is using templates to directly determine the size of the array:

template<size_t N>
inline void ParseParameters(int argc, const char* (&argv)[N])
{
    assert(argc >= 0 && (size_t) argc < N);
    ArgsManager::ParseParameters(argc, (char**) argv);
}
template<size_t N>
inline void ParseParameters(const char* (&argv)[N])
{
    ArgsManager::ParseParameters(N, (char**) argv);
}
...
testArgs.ParseParameters(1, argv_test); // to test only some args
testArgs.ParseParameters(argv_test); // to test all args

[maflcko]

Since passing an argc that does not specify the size of argv is only ever used in tests, you could pass argv_test.size() instead of 7 by switching to const std::array<const char*, 7> argv_test = {... braced-init-list ...}

[maflcko]

That makes it robust to future changes, but not robust to future changes that remove the trailing or the two trailing args. Imo such buggy changes must be covered by code review. Not excessive documentation. Note that we are talking about a function that spans about 20 lines... If code review does not work on that scale we have far worse issues.

[ajtowns]

Removed

[maflcko]

Concept ACK, but agree with @promag

[maflcko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK c99a3c32c830384a9959a468a13441fcd2e48a72
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJaTjV7AAoJENLqSFDnUoslYJUP+wRtblQkTEa0UlmhOiDk4KFa
BPiYWVsYCIfS2Mt7OtQq0RlxcGnNydneulsVQHzOhzTMo0DQdvKS32W5sUzhCjUa
JBc3McQ1kprl0NoiHoD3VuR2YbSdBPs8iwue14oD1ilNjGO3P6SlJdiv6Cg5svN0
FdpTEsJFkaZqIbceG4kfOlHnxqMhfUuaXoXCcN4KEPVG+FqUCE5fyxZAGlGEqwjW
WqkmcPK2caRXovv9DKTKHjPNp9KjGIR9zkKTd+upLMkormW9A5yCD9fyJCwjTBD2
eHc34VjjiRS043V3Q8bZpxMVGxZoPCv5ZZPol1whQY0fmbX3mTiDelp+IlCHX50L
LQ4x/zhQ18+EjP4tbYQYyT7TrHljt8v6ai14+zqjTXyfZDN2ba75SlfTzO6qxi9Z
Iw6eEIDK5HxnMmtCXLxNNV9eIjiaH9lnNzt0S177MRacDn2KClZcsDOEodXCqy99
OXvL4jYYZY/d86kLZskWfpYYNRoFf67s6ybYLj6coS5hMeRFBDJrmng0AcMohib6
+ixWmA8d4kXjZGgepRMkjMQtLaxvc0Sa0lAzAJ8io3jkB+0wbL9aap7Qb/hrybcu
/h7psyPdUyRTbOxuf3+7ke/X9xmY51vwshxbq3aGOPSidMbnPX2Tjo4szjAw7je2
oabzFOrUMgtIzDt4H+57
=kwru
-----END PGP SIGNATURE-----