Fix addrman crashes #1207
Merged
Fix addrman crashes #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made. Closes: bitcoin#1065, bitcoin#1156
|
ACK |
|
This has survived about 10 hours of running inside valgrind here on a node that previously crashed and with some tweaks to make it more likely to crash. It also survived a new node bringup. The code looks okay to me, so I'm going to go ahead and pull it in the hopes of getting more people testing it on master. |
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Fix addrman crashes
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
* Fix build on native MacOSX In cbc2e5 a bug got introduced while trying to special cases for Qt >= 5.2 * Use c++11 nullptr literal
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 10, 2020
9da9329 [Docs] Update build-unix.md (Fuzzbawls) Pull request description: This addresses a few things in the linux build documentation: 1. Bitcoin's PPA is now unmaintained for newer versions of Ubuntu (last supported version was 18.10). The PIVX PPA supports all current Ubuntu versions for providing BDB 4.8.30 (including the upcoming Focal Fossa 20 .04 LTS version). 2. Removes the (now)stale note about OpenSSL 1.1 and the removed `--with-unsupported-ssl` configure flag. 3. Adds a note about Qt's charts library availability on older Ubuntu/Debian distro versions. 4. Adds Qt's SVG & Charts libs to Fedora build instructions ACKs for top commit: random-zebra: utACK 9da9329 furszy: utACK 9da9329 Tree-SHA512: a1d270c590c95cbcaa543ca024d15e42aa427457462e7144411cdbe7781ba3734868b636a0601b2d3b0097656e297b574c1a92bbce51588087d23a775914a9e2
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
May 9, 2021
Pull request description: Add the ability to create managed tokens with a unique index, grant data, issuer data and holder data. Grant data is set on issuance, issuer data and holder data can be set at any point by the current issuer or holder respectively. Two new TX types are introduced, type 5 to send NFTs and type 201 to set the issuer and holder data. Grant data repurposes the memo field used in grant transactions that were not previously used other than to set data on the blockchain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made.
Closes: #1065, #1156