qa: Make TestNodeCLI command optional in send_cli #12089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1801-qaCliOptions
branch
from
faf5a49
to
fad4214
Compare
maflcko
changed the title
maflcko
changed the title
maflcko
changed the title
maflcko
force-pushed
the
Mf1801-qaCliOptions
branch
from
fad4214
to
fab04c3
Compare
|
Tested ACK fab04c3f55715f8d63ae88d087e9ea83f525a670 |
ryanofsky
reviewed
Jan 22, 2018
| if named_args: | ||
| p_args += ["-named"] | ||
| p_args += [command] + pos_args + named_args | ||
| if command: |
There was a problem hiding this comment.
Suggest s/command/command is not None/ so if 0 or False or [] or "" is passed, it will trigger appropriate python type errors or "method not found" error instead of "too few parameters" error.
| @@ -213,16 +213,16 @@ class TestNodeCLI(): | |||
| """Interface to bitcoin-cli for an individual node""" | |||
|
|
|||
| def __init__(self, binary, datadir): | |||
| self.args = [] | |||
| self.options = [] | |||
There was a problem hiding this comment.
Rename seems appropriate, but ideally it would be in a separate commit, since it is bigger than the real change, and doesn't even overlap with it.
That is the name in bitcoin-cli -help
maflcko
force-pushed
the
Mf1801-qaCliOptions
branch
from
fab04c3
to
faf1ab0
Compare
maflcko
force-pushed
the
Mf1801-qaCliOptions
branch
from
faf1ab0
to
fae7b14
Compare
|
Tested ACK fae7b14 |
maflcko
pushed a commit
that referenced
this pull request
Jan 24, 2018
fae7b14 qa: Make TestNodeCLI command optional in send_cli (MarcoFalke) ffffb10 qa: Rename cli.args to cli.options (MarcoFalke) Pull request description: Makes the `command` optional, since there are valid bitcoin-cli calls that have no `command`: * `bitcoin-cli -?` * `bitcoin-cli -getinfo` * ... Also, rename self.args to self.options, since that is the name in the `bitcoin-cli -help` documentation. Tree-SHA512: f49c06024e78423301d70782946d47c0fb97a26876afba0a1f71ed329f5d7124aee4c2df520c7af74079bf9937851902f7be9c54abecc28dc29274584804d46c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 7, 2020
fae7b14 qa: Make TestNodeCLI command optional in send_cli (MarcoFalke) ffffb10 qa: Rename cli.args to cli.options (MarcoFalke) Pull request description: Makes the `command` optional, since there are valid bitcoin-cli calls that have no `command`: * `bitcoin-cli -?` * `bitcoin-cli -getinfo` * ... Also, rename self.args to self.options, since that is the name in the `bitcoin-cli -help` documentation. Tree-SHA512: f49c06024e78423301d70782946d47c0fb97a26876afba0a1f71ed329f5d7124aee4c2df520c7af74079bf9937851902f7be9c54abecc28dc29274584804d46c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 8, 2020
fae7b14 qa: Make TestNodeCLI command optional in send_cli (MarcoFalke) ffffb10 qa: Rename cli.args to cli.options (MarcoFalke) Pull request description: Makes the `command` optional, since there are valid bitcoin-cli calls that have no `command`: * `bitcoin-cli -?` * `bitcoin-cli -getinfo` * ... Also, rename self.args to self.options, since that is the name in the `bitcoin-cli -help` documentation. Tree-SHA512: f49c06024e78423301d70782946d47c0fb97a26876afba0a1f71ed329f5d7124aee4c2df520c7af74079bf9937851902f7be9c54abecc28dc29274584804d46c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
commandoptional, since there are valid bitcoin-cli calls that have nocommand:bitcoin-cli -?bitcoin-cli -getinfoAlso, rename self.args to self.options, since that is the name in the
bitcoin-cli -helpdocumentation.