[tests] Rename functional tests #11774

ajtowns · 2017-11-27T17:16:28Z

This PR changes the functional tests to have a consistent naming scheme:

tests for individual RPC methods are named rpc_...
tests for interfaces (REST, ZMQ, RPC features) are named interface_...
tests that explicitly test the p2p interface are named p2p_...
tests for wallet features are named wallet_...
tests for mining features are named mining_...
tests for mempool behaviour are named mempool_...
tests for full features that aren't wallet/mining/mempool are named feature_...

Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance.

ajtowns · 2017-11-30T09:43:42Z

Split into two PRs -- changes in #11796 should be reviewed and merged first. This PR will just be the actual renaming, so is easy to automatically regenerate, and should be easy to review once the previous PR is merged. Have also split the renaming into multiple commits by test area, which I think makes it a bit easier to review, but happy to revert that if not.

Marking as WIP until #11796 is actually merged, since I'm expecting this to require a bunch of rebases.

ajtowns · 2017-12-05T09:56:28Z

Updated to match fixes in parent PR, rebased to current master to fix merge conflicts, added final commit doing away with EXPECTED_VIOLATION_COUNT (but still allowing tests to pass with a warning if there's 10 or fewer violations)

5fecd84 [tests] Remove redundant import in blocktools.py test (Anthony Towns) 9b20bb4 [tests] Check tests conform to naming convention (Anthony Towns) 7250b4e [tests] README.md nit fixes (Anthony Towns) 82b2712 [tests] move witness util functions to blocktools.py (John Newbery) 1e10854 [tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting #11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80

maflcko · 2018-01-15T13:49:50Z

@ajtowns Is this still WIP?

jnewbery · 2018-01-15T14:34:58Z

Tested ACK: c3fd1259f14e513934f6b2eee1f7febe708d04c7

ajtowns · 2018-01-15T14:35:14Z

@MarcoFalke if it's merged, I think github will decide that any other PRs that touch any of the renamed test cases have conflicts and can't be automatically merged. I was going to put together a list of those PRs before removing the WIP tag, but it's late now, so tomorrow.

ajtowns · 2018-01-16T10:32:17Z

The following PRs have the 0.16.0 milestone and touch test cases:

Add a lock to the wallet directory #11904: M test/functional/multiwallet.py (merged while I was writing this comment...)
Clamp walletpassphrase timeout to 2^30 seconds and check its bounds #12101: M test/functional/wallet-encryption.py
[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH #12119: M test/functional/address_types.py

I think github will decide there's conflicts and a rebase is required in whichever of these PRs get merged later (ie if 12119, 12101 or 11904 is merged first, github will claim this PR has conflicts; if this one is merged first, github will claim those PRs have conflicts).

There's a few PRs marked 0.17.0 or Future with the same issue along with some PRs that already have merge conflicts according to github. That leaves the following PRs that will likely "conflict" with this PR, that don't have a milestone and are currently mergeable:

Add updatepeer RPC #10160 Add updatepeer RPC (jnewbery)
New -includeconf argument for including external configuration files #10267 New -includeconf argument for including external configuration files (kallewoof)
[WIP] [test] Test abortrescan command. #10367 [test] Test abortrescan command. (kallewoof)
[WIP] [wallet] Optional '-avoidreuse' flag which defaults to not reusing addresses in sends #10386 [wallet] Optional '-avoidreuse' flag which defaults to not reusing addresses in sends (kallewoof)
ZMQ: add publishers for wallet transactions. #10554 ZMQ: add publishers for wallet transactions. (somdoron)
Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients #10595 Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients (luke-jr)
RPC: Introduce getblockstats to plot things #10757 RPC: Introduce getblockstats to plot things (jtimon)
[rpc] Verbose flags for chaining and scripting #10877 [rpc] Verbose flags for chaining and scripting (kallewoof)
Allow 2 simultaneous (compact-)block downloads #10984 Allow 2 simultaneous (compact-)block downloads (TheBlueMatt)
[RPC] verifytxoutproof returns object including blockhash #11120 [RPC] verifytxoutproof returns object including blockhash (instagibbs)
RPC: add weight to mempool entry output #11256 RPC: add weight to mempool entry output (esotericnonsense)
[wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option #11413 [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option (kallewoof)
[REST] added blockhash api, tests and documentation #11765 [REST] added blockhash api, tests and documentation (aaron-hanson)
[tests] Change invalidtxrequest to use BitcoinTestFramework #11771 [tests] Change invalidtxrequest to use BitcoinTestFramework (jnewbery)
[tests] Change invalidblockrequest to use BitcoinTestFramework #11772 [tests] Change invalidblockrequest to use BitcoinTestFramework (jnewbery)
[tests] Change feature_block.py to use BitcoinTestFramework #11773 [tests] Change p2p-fullblocktest to use BitcoinTestFramework (jnewbery)
[tests] Change feature_csv_activation.py to use BitcoinTestFramework #11817 [tests] Change bip68-112-113-p2p to use BitcoinTestFramework (jnewbery)
qa: Prepare tests for Windows #11858 qa: Prepare tests for Windows (laanwj, MarcoFalke) (MarcoFalke)
QA: segwit.py: s/find_unspent/find_spendable_utxo/ #11869 QA: segwit.py: s/find_unspent/find_spendable_utxo/ (jtimon)
[rpc] createrawtransaction: Accept sorted outputs #11872 [rpc] createrawtransaction: Accept sorted outputs (MarcoFalke)
fix: add support for CORS headers and pre-flight request #12040 fix: add support for CORS headers and pre-flight request (lionello)
Improve getchaintxstats test coverage #12083 Improve getchaintxstats test coverage (promag)
qa: Make TestNodeCLI command optional in send_cli #12089 qa: Make TestNodeCLI command optional in send_cli (MarcoFalke)
[rpc] [wallet] Allow specifying the output index when using bumpfee #12096 [rpc] [wallet] Allow specifying the output index when using bumpfee (kallewoof)
Build previous releases and run functional tests #12134 Build previous releases and run functional tests (Sjors)
Implement BIP 174 Partially Signed Bitcoin Transactions serialization and RPCs #12136 Implement BIP 174 Partially Signed Bitcoin Transactions (achow101)
Track best-possible-headers #12138 Track best-possible-headers (TheBlueMatt)
Wallet: Support disabling implicit Segwit operation #12146 Wallet: Support disabling implicit Segwit operation (luke-jr)
Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished #12172 Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (jtimon)
Add scantxoutset RPC method #12196 Add scantxoutset RPC method (jonasschnelli)

maflcko · 2018-01-17T00:40:21Z

I think it makes sense to merge this into the 0.16 branch, so it is easier to switch back and forth between last release and master and have the same name for tests. I'd propose to wait for the merge of #12101 and #12119, then rebase on master and merge.

ajtowns · 2018-01-23T07:09:22Z

Rebased. Will still conflict with #12213 (which already needs a rebase) and #12119 so either this will need to be updated after they're merged, or they will need updating after this is merged.

jnewbery · 2018-01-23T16:17:03Z

This should have a 0.16 milestone.

I think it's also fine to merge before #12213 and #12119 since both of those have review comments or rebasing to do anyway.

maflcko · 2018-01-23T18:10:15Z

test/functional/test_runner.py

       test scripts don't start with one of the allowed name prefixes."""
-    EXPECTED_VIOLATION_COUNT = 77

    # LEEWAY is provided as a transition measure, so that pull-requests
    # that introduce new tests that don't conform with the naming


Might as well set LEEWAY to 0, as I don't see a need for this.

After all, we want travis to fail if some test is named inproperly. Otherwise, it would lead to unnecessary fixup pull requests.

Hmm, you might be right -- no specific example comes to mind, but I'm still a bit hesistant about removing LEEWAY prior to 0.16 branching from master.

I've put a commit that drops LEEWAY in #12252 ; assuming you definitely want it and Travis is happy with it, can merge it into this PR; otherwise can just merge #12252 when 0.16 branches off?

maflcko · 2018-01-24T14:33:30Z

@ajtowns Needs rebase

ajtowns · 2018-01-25T00:12:00Z

Rebased

maflcko · 2018-01-25T01:42:25Z

6f881cc [tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns) 3150b3f [tests] Rename misc functional tests. (Anthony Towns) 81b79f2 [tests] Rename rpc_* functional tests. (Anthony Towns) 61b8f7f [tests] Rename p2p_* functional tests. (Anthony Towns) 90600bc [tests] Rename wallet_* functional tests. (Anthony Towns) ca6523d [tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16

jnewbery · 2018-01-25T12:34:23Z

Thanks for maintaining this PR @ajtowns . You're a patienter man than I!

125f4a4 [tests] Require all tests to follow naming convention (Anthony Towns) Pull request description: Based on top of #11774 Tree-SHA512: 1eb156b5a97b30c203b7b0ad3d2055b391ef825e2e57805c7745b5259a9b1caaa115768ec225452f12f354e550f83e071f9c6fee2c36698b4679191895aab8de

8a6c62b [tests] Update README after filename change (Conor Scott) Pull request description: Update test README after filename changes from #11774 Tree-SHA512: 2dd2e4d12e9e8bef4e76996f610aea758d221f8da31e14163168a6a0c635d32fc547542112d43c37fa165c289572b12798caf467fd933082f8eb129f8e5d6ca8

5fecd84 [tests] Remove redundant import in blocktools.py test (Anthony Towns) 9b20bb4 [tests] Check tests conform to naming convention (Anthony Towns) 7250b4e [tests] README.md nit fixes (Anthony Towns) 82b2712 [tests] move witness util functions to blocktools.py (John Newbery) 1e10854 [tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting bitcoin#11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80

6f881cc [tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns) 3150b3f [tests] Rename misc functional tests. (Anthony Towns) 81b79f2 [tests] Rename rpc_* functional tests. (Anthony Towns) 61b8f7f [tests] Rename p2p_* functional tests. (Anthony Towns) 90600bc [tests] Rename wallet_* functional tests. (Anthony Towns) ca6523d [tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16

5fecd84 [tests] Remove redundant import in blocktools.py test (Anthony Towns) 9b20bb4 [tests] Check tests conform to naming convention (Anthony Towns) 7250b4e [tests] README.md nit fixes (Anthony Towns) 82b2712 [tests] move witness util functions to blocktools.py (John Newbery) 1e10854 [tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting bitcoin#11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80

6f881cc [tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns) 3150b3f [tests] Rename misc functional tests. (Anthony Towns) 81b79f2 [tests] Rename rpc_* functional tests. (Anthony Towns) 61b8f7f [tests] Rename p2p_* functional tests. (Anthony Towns) 90600bc [tests] Rename wallet_* functional tests. (Anthony Towns) ca6523d [tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16

5fecd84 [tests] Remove redundant import in blocktools.py test (Anthony Towns) 9b20bb4 [tests] Check tests conform to naming convention (Anthony Towns) 7250b4e [tests] README.md nit fixes (Anthony Towns) 82b2712 [tests] move witness util functions to blocktools.py (John Newbery) 1e10854 [tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting bitcoin#11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80

6f881cc [tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns) 3150b3f [tests] Rename misc functional tests. (Anthony Towns) 81b79f2 [tests] Rename rpc_* functional tests. (Anthony Towns) 61b8f7f [tests] Rename p2p_* functional tests. (Anthony Towns) 90600bc [tests] Rename wallet_* functional tests. (Anthony Towns) ca6523d [tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16

* Merge bitcoin#11796: [tests] Functional test naming convention 5fecd84 [tests] Remove redundant import in blocktools.py test (Anthony Towns) 9b20bb4 [tests] Check tests conform to naming convention (Anthony Towns) 7250b4e [tests] README.md nit fixes (Anthony Towns) 82b2712 [tests] move witness util functions to blocktools.py (John Newbery) 1e10854 [tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting bitcoin#11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80 * update violation count Signed-off-by: pasta <pasta@dashboost.org> * Merge bitcoin#11774: [tests] Rename functional tests 6f881cc [tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns) 3150b3f [tests] Rename misc functional tests. (Anthony Towns) 81b79f2 [tests] Rename rpc_* functional tests. (Anthony Towns) 61b8f7f [tests] Rename p2p_* functional tests. (Anthony Towns) 90600bc [tests] Rename wallet_* functional tests. (Anthony Towns) ca6523d [tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16 * rename tests and edit associated strings to align test-suite with test name standards Signed-off-by: pasta <pasta@dashboost.org> * fix grammar in test/functional/test_runner.py Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * ci: Fix excluded test names * rename feature_privatesend.py to rpc_privatesend.py Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>

125f4a4 [tests] Require all tests to follow naming convention (Anthony Towns) Pull request description: Based on top of bitcoin#11774 Tree-SHA512: 1eb156b5a97b30c203b7b0ad3d2055b391ef825e2e57805c7745b5259a9b1caaa115768ec225452f12f354e550f83e071f9c6fee2c36698b4679191895aab8de

The block test was renamed from `p2p-fullblocks.py` to `feature_block.py` in commit ca6523d (PR bitcoin#11774).

jnewbery mentioned this pull request Nov 27, 2017

[tests] rename functional tests #11047

Closed

fanquake added the Tests label Nov 27, 2017

ajtowns mentioned this pull request Nov 30, 2017

[tests] Functional test naming convention #11796

Merged

ajtowns changed the title ~~[tests] Rename functional tests~~ [WIP] [tests] Rename functional tests Nov 30, 2017

ajtowns force-pushed the rename_tests branch from 9077d0b to 1b76588 Compare November 30, 2017 09:40

ajtowns force-pushed the rename_tests branch 2 times, most recently from 15d692d to 08ea198 Compare December 5, 2017 08:29

ajtowns force-pushed the rename_tests branch 2 times, most recently from 42588e5 to d522a5b Compare December 7, 2017 18:15

ajtowns mentioned this pull request Dec 10, 2017

Add Travis check for unused Python imports #11835

Merged

ajtowns force-pushed the rename_tests branch 2 times, most recently from 9bae101 to 838ddf1 Compare December 13, 2017 03:18

ajtowns force-pushed the rename_tests branch 2 times, most recently from af48e03 to aeb35d9 Compare January 7, 2018 21:17

ajtowns force-pushed the rename_tests branch 2 times, most recently from 89ffd28 to 75ee34c Compare January 12, 2018 01:48

ajtowns force-pushed the rename_tests branch from 75ee34c to c3fd125 Compare January 15, 2018 10:42

ajtowns mentioned this pull request Jan 17, 2018

Start renaming functional tests & update test runner #12207

Closed

ajtowns force-pushed the rename_tests branch from c3fd125 to e84b6e4 Compare January 23, 2018 06:37

ajtowns changed the title ~~[WIP] [tests] Rename functional tests~~ [tests] Rename functional tests Jan 23, 2018

maflcko reviewed Jan 23, 2018

View reviewed changes

ajtowns mentioned this pull request Jan 23, 2018

Require all tests to follow naming convention #12252

Merged

ajtowns added 6 commits January 25, 2018 09:44

[tests] Rename feature_* functional tests.

ca6523d

[tests] Rename wallet_* functional tests.

90600bc

[tests] Rename p2p_* functional tests.

61b8f7f

[tests] Rename rpc_* functional tests.

81b79f2

[tests] Rename misc functional tests.

3150b3f

[tests] Remove EXPECTED_VIOLATION_COUNT

6f881cc

ajtowns force-pushed the rename_tests branch from e84b6e4 to 6f881cc Compare January 25, 2018 00:10

maflcko merged commit 6f881cc into bitcoin:master Jan 25, 2018

conscott mentioned this pull request Feb 6, 2018

Update README after filename change #12363

Merged

ryanofsky mentioned this pull request Feb 12, 2018

Rename account to label where appropriate #11536

Merged

theStack added a commit to theStack/bitcoin that referenced this pull request Aug 15, 2021

test: fix reference to block processing test in p2p_segwit.py

de522a0

The block test was renamed from `p2p-fullblocks.py` to `feature_block.py` in commit ca6523d (PR bitcoin#11774).

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Rename functional tests #11774

[tests] Rename functional tests #11774

ajtowns commented Nov 27, 2017 •

edited

ajtowns commented Nov 30, 2017

ajtowns commented Dec 5, 2017

maflcko commented Jan 15, 2018

jnewbery commented Jan 15, 2018

ajtowns commented Jan 15, 2018

ajtowns commented Jan 16, 2018 •

edited

maflcko commented Jan 17, 2018

ajtowns commented Jan 23, 2018

jnewbery commented Jan 23, 2018

maflcko Jan 23, 2018

ajtowns Jan 23, 2018

maflcko commented Jan 24, 2018

ajtowns commented Jan 25, 2018

maflcko commented Jan 25, 2018

jnewbery commented Jan 25, 2018

[tests] Rename functional tests #11774

[tests] Rename functional tests #11774

Conversation

ajtowns commented Nov 27, 2017 • edited

ajtowns commented Nov 30, 2017

ajtowns commented Dec 5, 2017

maflcko commented Jan 15, 2018

jnewbery commented Jan 15, 2018

ajtowns commented Jan 15, 2018

ajtowns commented Jan 16, 2018 • edited

maflcko commented Jan 17, 2018

ajtowns commented Jan 23, 2018

jnewbery commented Jan 23, 2018

maflcko Jan 23, 2018

Choose a reason for hiding this comment

ajtowns Jan 23, 2018

Choose a reason for hiding this comment

maflcko commented Jan 24, 2018

ajtowns commented Jan 25, 2018

maflcko commented Jan 25, 2018

jnewbery commented Jan 25, 2018

ajtowns commented Nov 27, 2017 •

edited

ajtowns commented Jan 16, 2018 •

edited