Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold mempool.cs for the duration of ATMP. #12368

Merged
merged 2 commits into from Feb 8, 2018
Merged

Hold mempool.cs for the duration of ATMP. #12368

merged 2 commits into from Feb 8, 2018

Commits on Feb 6, 2018

  1. Hold mempool.cs for the duration of ATMP. 

    This resolves an issue where getrawmempool() can race mempool
notification signals. Intuitively we use mempool.cs as a "read
lock" on the mempool with cs_main being the write lock, so holding
the read lock intermittently while doing write operations is
somewhat strange.
This also avoids the introduction of cs_main in getrawmempool()
which reviewers objected to in the previous fix in bitcoin#12273
    @TheBlueMatt
    TheBlueMatt committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    85aa839 View commit details
    Browse the repository at this point in the history

  2. Add braces to meet code style on line-after-the-one-changed.

    @TheBlueMatt
    TheBlueMatt committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    02fc886 View commit details
    Browse the repository at this point in the history