Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce variable scopes #12780

Merged
merged 1 commit into from Mar 30, 2018
Merged

Reduce variable scopes #12780

merged 1 commit into from Mar 30, 2018

Conversation

practicalswift
Copy link
Contributor

Reduce variable scopes.

promag
promag reviewed Mar 25, 2018
View reviewed changes
Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

src/qt/recentrequeststablemodel.cpp Outdated
for (int i = 0; i < count; ++i)
{
rec = &list[row+i];
const RecentRequestEntry *rec = &list[row+i];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecentRequestEntry* rec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Empact :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't mean to remove const, sorry, just the space..

@practicalswift practicalswift force-pushed the limit-variable-scopes branch 2 times, most recently from 16dd30e to 35665f2 Compare March 25, 2018 21:10
Empact
Empact reviewed Mar 26, 2018
View reviewed changes
src/qt/recentrequeststablemodel.cpp Outdated
for (int i = 0; i < count; ++i)
{
rec = &list[row+i];
RecentRequestEntry *rec = &list[row+i];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

@practicalswift
Copy link
Contributor Author

Please re-review :-)

@Empact
Copy link
Member

Empact commented Mar 27, 2018

utACK 6a318e4

@maflcko
Copy link
Member

maflcko commented Mar 27, 2018

utACK 6a318e4

@maflcko maflcko merged commit 6a318e4 into bitcoin:master Mar 30, 2018
maflcko pushed a commit that referenced this pull request Mar 30, 2018
Merge #12780: Reduce variable scopes
be299c4 
6a318e4 Reduce variable scopes (practicalswift)

Pull request description:

  Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 27, 2020
@PastaPastaPasta
Merge bitcoin#12780: Reduce variable scopes
ffa2839 
6a318e4 Reduce variable scopes (practicalswift)

Pull request description:

  Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 22, 2020
@PastaPastaPasta
Merge bitcoin#12780: Reduce variable scopes
79b0c69 
6a318e4 Reduce variable scopes (practicalswift)

Pull request description:

  Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 27, 2020
@PastaPastaPasta
Merge bitcoin#12780: Reduce variable scopes
b4f29b6 
6a318e4 Reduce variable scopes (practicalswift)

Pull request description:

  Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714
@practicalswift practicalswift deleted the limit-variable-scopes branch April 10, 2021 19:34
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Feb 21, 2022
@gades
Merge bitcoin#12780: Reduce variable scopes
45580ac 
6a318e4 Reduce variable scopes (practicalswift)

Pull request description:

  Reduce variable scopes.

Tree-SHA512: 5c7735344024cb6cd310e739886dc811a64b640a0d6aac8b3d04f49e5987d6ff6676d978890bc84f1460527d92217176a79b007f0bf6b4147c04abfec2c67714
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Empact Empact Empact left review comments

@promag promag promag left review comments

@dcousens dcousens dcousens approved these changes

@randolf randolf randolf approved these changes

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@practicalswift @Empact @maflcko @dcousens @promag @randolf @fanquake