Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Show the Window when double clicking the taskbar icon #12999

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
5 participants
@ken2812221
Copy link
Member

ken2812221 commented Apr 16, 2018

fix #12838

@ken2812221 ken2812221 force-pushed the ken2812221:qt-fix branch to 67bf2aa Apr 16, 2018

@fanquake fanquake added the GUI label Apr 17, 2018

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Apr 18, 2018

@jonasschnelli Could you also do a gitian build here?

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Apr 18, 2018

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Apr 18, 2018

I've tested the Win64 gitian build, and can confirm that the double click -> white-screen behaviour reported in #12838 is fixed by 67bf2aa. Have not tested on any other OS, or checked if any other minimising behaviours etc are affected yet.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Apr 23, 2018

utACK 67bf2aa

@laanwj laanwj merged commit 67bf2aa into bitcoin:master Apr 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 23, 2018

Merge #12999: qt: Show the Window when double clicking the taskbar icon
67bf2aa qt:Show the entire Window when double clicking on taskbar (Chun Kuan Lee)

Pull request description:

  fix #12838

Tree-SHA512: 4498bc1fe52efeed3768d6bdd7941e4b036d52ae80d9c1b6679c6daa3a62aeda4cff0c91fe1c65afaea6049c59cb0296fdcbff63ecb342d518615a92361fda7f

@ken2812221 ken2812221 deleted the ken2812221:qt-fix branch Apr 23, 2018

@MarcoFalke MarcoFalke added this to the 0.16.1 milestone Apr 23, 2018

@fanquake fanquake referenced this pull request Apr 24, 2018

Merged

[0.16] Backports #12967

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 26, 2018

laanwj added a commit that referenced this pull request May 16, 2018

Merge #12967: [0.16] Backports
8fca086 List support for BIP173 in bips.md (Pieter Wuille)
9645aa6 Remove blockmaxsize option from init.cpp (fanquake)
7847b92 Default to defining endian-conversion DECLs in compat w/o config (Matt Corallo)
1720eb3 qt:Show the entire Window when double clicking on taskbar (Chun Kuan Lee)
e055bc0 depends: Fix Qt build with XCode 9.3 (fanquake)
0684cf9 Avoid launching as admin when NSIS installer ends. (JeremyRand)
e802c22 [config] Remove blockmaxsize option (John Newbery)
f118a7a Fix illegal default `addProxy` and `addrSeparateProxyTor` settings. (251)
f60e84d Limit the number of IPs we use from each DNS seeder (e0)

Pull request description:

  Backports:
  - #12626 Limit the number of IPs addrman learns from each DNS seeder
  - #12650 gui: Fix issue: "default port not shown correctly in settings dialog"
  - #12756 [config] Remove blockmaxsize option
  - #12985 Windows: Avoid launching as admin when NSIS installer ends.
  - #12946 depends: Fix Qt build with XCode 9.3
  - #12998 Default to defining endian-conversion DECLs in compat w/o config
  - #12999 qt: Show the Window when double clicking the taskbar icon
  - #13064 List support for BIP173 in bips.md

  to the 0.16 branch.

Tree-SHA512: 3e6b47c54b2cd2bdd81fbc6176cb31e46423f6e05988984d3a09b3535e3cee101ffb071cf753a4beff3c9f0521eb5de4b7c0424a3e97da801d56b4015847ac0f

HashUnlimited pushed a commit to chaincoin/chaincoin that referenced this pull request Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.