Make sure LC_ALL=C is set in all shell scripts

[practicalswift]

Make sure LC_ALL=C is set when using grep range expressions.

Make sure LC_ALL=C is set in all shell scripts.

From the grep(1) documentation:

Within a bracket expression, a range expression consists of two characters separated by a hyphen. It matches any single character that sorts between the two characters, inclusive, using the locale's collating sequence and character set. For example, in the default C locale, [a-d] is equivalent to [abcd]. Many locales sort characters in dictionary order, and in these locales [a-d] is typically not equivalent to [abcd]; it might be equivalent to [aBbCcDd], for example. To obtain the traditional interpretation of bracket expressions, you can use the C locale by setting the LC_ALL environment variable to the value C.

Context: Locale issue found when reviewing #13450

[laanwj]

Maybe export LC_ALL=C at the beginning of these scripts, to rule out unexpected locale dependency in other commands too.
(this also avoids making the code look even more cluttered)

[practicalswift]

@laanwj Good idea. Now enforcing export LC_ALL=C. Please re-review :-)

[maflcko]

How would shellcheck segfault on this? 🤕

test/lint/lint-shell.sh: line 29:  8402 Segmentation fault      (core dumped) shellcheck -e SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181 $(git ls-files -- "*.sh" | grep -vE 'src/(secp256k1|univalue)/')

[practicalswift]

@MarcoFalke Oh, that's weird! I'm unable to reproduce locally. Will try to find time to investigate soon!

[maflcko]

Presumably caused by the non-ascii char in https://github.com/practicalswift/bitcoin/blob/0f556d2e6d19e5fd86712bb5f4b0506924740ae3/test/lint/lint-python.sh#L65

[practicalswift]

@MarcoFalke Tried removing that but same issue :-\

[laanwj]

Seems like an upstream bug then, with the version installed by Travis, if you can't reproduce it locally?

[ken2812221]

Looks like travis has already installed shellcheck v0.4.6, but we reinstall v0.3.3 from ubuntu repo.

Edit: Tried not to downgrade shellcheck, not going to work.

[practicalswift]

Worked around the shellcheck issue by adding an "opt in to locale dependence" mechanism which is now in used for test/lint/lint-shell.sh.

Please re-review :-)

[laanwj]

Still segfaults?!?

[practicalswift]

@laanwj LC_ALL=C was exported by the lint script runner test/lint/lint-all.sh and thus inherited also by test/lint/lint-shell.sh. Now "opting in to locale dependence" also in lint-all.sh to allow for the linting scripts to opt in/out out of locale dependences themselves :-)

[laanwj]

Good. We should not forget to remove this workaround when we'll be able to use a newer shellcheck, it's a bit yucky, but checking all scripts but two is much better than nothing.
utACK 47776a9

[ken2812221]

utACK 47776a9

[maflcko]

@practicalswift This fails travis with

test/lint/lint-all.sh
Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in test/lint/lint-python-utf8-encoding.sh
^---- failure generated from test/lint/lint-shell-locale.sh

[practicalswift]

@MarcoFalke Oh, thanks! Fixed by #13494.