-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: Run bench_bitcoin once #13811
Conversation
0454a4c
to
fa1f75a
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Maybe it would make more sense to introduce an additional stage "benchmark" which does a non-debug build and perform the benchmark in there? Also it would clearly separate it visually when looking at travis. The only thing that sucks about this approach that it requires an additional build = additional travis run time. But given the extensive caching being done this should be okay. |
Please see https://bitcoinperf.com/ for these. The one here is specifically designed to run everything in less than a 1/10 of a second. ( |
Ah, cool! Didn't know about this site. Since this site does exist – what is the purpose of running the benchmark in the CI pipeline though? Is it to check that a commit didn't break the benchmark, i.e. to check that is runs successfully, not how fast actually? I think as a contributor who's new to the project I would love to see a comment communicating that intent next to it (if this is the intent). Some of the lines in the |
fa1f75a
to
fa7a3a1
Compare
Updated commit and OP based on your feedback |
utACK fa7a3a1 |
ACK fa7a3a1 |
utACK fa7a3a1 |
utACK fa7a3a1
Very good idea. |
fa7a3a1 travis: Run bench_bitcoin once (MarcoFalke) Pull request description: The bench should be run once just to make sure it doesn't crash or hit assertions. Closes: #13810 Tree-SHA512: f34038c47535fb5cbd32b5eadd3ae84c294b2dc84c9d3bf3ccbbfb88a927b76f044ed24fb26f51a10d21341916c9dd0cdc98fab9d908cb90333c8ea7d4d4f620
The bench should be run once just to make sure it doesn't crash or hit assertions.
Closes: #13810