Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Run bench_bitcoin once #13811

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jul 30, 2018

The bench should be run once just to make sure it doesn't crash or hit assertions.

Closes: #13810

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 31, 2018

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@scravy
Copy link
Contributor

scravy commented Aug 1, 2018

WARNING: This is a debug build - may result in slower benchmarks.

Maybe it would make more sense to introduce an additional stage "benchmark" which does a non-debug build and perform the benchmark in there?

Also it would clearly separate it visually when looking at travis. The only thing that sucks about this approach that it requires an additional build = additional travis run time. But given the extensive caching being done this should be okay.

@maflcko
Copy link
Member Author

maflcko commented Aug 1, 2018

Maybe it would make more sense to introduce an additional stage "benchmark" which does a non-debug build and perform the benchmark in there?

Please see https://bitcoinperf.com/ for these. The one here is specifically designed to run everything in less than a 1/10 of a second. (scaling=0.001)

@scravy
Copy link
Contributor

scravy commented Aug 1, 2018

Ah, cool! Didn't know about this site.

Since this site does exist – what is the purpose of running the benchmark in the CI pipeline though? Is it to check that a commit didn't break the benchmark, i.e. to check that is runs successfully, not how fast actually?

I think as a contributor who's new to the project I would love to see a comment communicating that intent next to it (if this is the intent). Some of the lines in the .travis.yml are incomprehensible (for example I have no idea which steps require the before-install step of removing everything that contains /opt/python from the path). That should help maintain it.

@maflcko
Copy link
Member Author

maflcko commented Aug 1, 2018

Updated commit and OP based on your feedback

@jamesob
Copy link
Member

jamesob commented Aug 1, 2018

utACK fa7a3a1

@scravy
Copy link
Contributor

scravy commented Aug 2, 2018

ACK fa7a3a1

@ken2812221
Copy link
Contributor

utACK fa7a3a1

@laanwj
Copy link
Member

laanwj commented Aug 2, 2018

utACK fa7a3a1

The one here is specifically designed to run everything in less than a 1/10 of a second. (scaling=0.001)

Very good idea.

@laanwj laanwj merged commit fa7a3a1 into bitcoin:master Aug 2, 2018
laanwj added a commit that referenced this pull request Aug 2, 2018
fa7a3a1 travis: Run bench_bitcoin once (MarcoFalke)

Pull request description:

  The bench should be run once just to make sure it doesn't crash or hit assertions.

  Closes: #13810

Tree-SHA512: f34038c47535fb5cbd32b5eadd3ae84c294b2dc84c9d3bf3ccbbfb88a927b76f044ed24fb26f51a10d21341916c9dd0cdc98fab9d908cb90333c8ea7d4d4f620
@maflcko maflcko deleted the Mf1808-travisBench branch August 2, 2018 11:59
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qa: Travis should run the bench_bitcoin in one of the jobs
7 participants