Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Replace usage of tostring() with tobytes() #13963

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
5 participants
@dongcarl
Copy link
Contributor

commented Aug 14, 2018

tostring() is deprecated as of python 3.7 and results in stderr output
causing tests to fail

tests: Replace usage of tostring() with tobytes()
tostring() is deprecated as of python 3.7 and results in stderr output
causing tests to fail

@fanquake fanquake added the Tests label Aug 14, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

utACK 8845c8a

tostring() was renamed to tobytes() in Python 3.2.

@achow101

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

utACK 8845c8a

1 similar comment
@domob1812

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2018

utACK 8845c8a

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

utACK 8845c8a, checked that this is the only case

ken2812221 pushed a commit to ken2812221/bitcoin that referenced this pull request Aug 14, 2018

Merge bitcoin#13963: tests: Replace usage of tostring() with tobytes()
8845c8a tests: Replace usage of tostring() with tobytes() (Carl Dong)

Pull request description:

  tostring() is deprecated as of python 3.7 and results in stderr output
  causing tests to fail

Tree-SHA512: 8c5bbd6c6127490922add98543ee7719d19e11200e081784adef2f026ddf90d7735da7d0fb41fa4307d0d3450a27e126752c2b01cbd79b0c8a695855aed080ac

@laanwj laanwj merged commit 8845c8a into bitcoin:master Aug 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

instagibbs added a commit to ElementsProject/elements that referenced this pull request Nov 27, 2018

Merge #468: Replace deprecated tostring with tobytes
00315c8 Replace deprecated tostring with tobytes (Carl Dong)

Pull request description:

  Upstream: bitcoin/bitcoin#13963

Tree-SHA512: 667cb8799941e7c3a567e8c9b77b77fdf1b838d170b5de2c51618e6d1284216039cb39e44f9650b6a7de325036a0d2c80aeb9cf5387da7e183f33461a31c9727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.