Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use fs:: over boost::filesystem:: #13982

Merged
merged 1 commit into from Aug 15, 2018
Merged

refactor: use fs:: over boost::filesystem:: #13982

merged 1 commit into from Aug 15, 2018

Conversation

fanquake
Copy link
Member

Noticed while investigating #13973.

@laanwj
Copy link
Member

laanwj commented Aug 15, 2018

thanks
obvious utACK 4b3b85c

@practicalswift
Copy link
Contributor

utACK 4b3b85c

Thanks for helping getting rid of Boost! Every step helps.

@DrahtBot
Copy link
Contributor

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko merged commit 4b3b85c into bitcoin:master Aug 15, 2018
This was referenced Aug 15, 2018
Merged
Merged
@fanquake fanquake deleted the use-filesystem-wrapper branch August 15, 2018 23:37
@Bushstar Bushstar mentioned this pull request Sep 4, 2018
Merged
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 24, 2020
Merge #13982: refactor: use fs:: over boost::filesystem::
8043115 
Summary:
4b3b85c597 refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating #13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

Backport remaining of Core [[https://github.com/bitcoin/bitcoin/pull/13982/files | PR13982]]
bitcoin/bitcoin#13982

Review note: changes to `qt/guiutil.cpp` were made in D3219.  Changes to
`wallet/rpcdump.cpp` were made in D1165.

Test Plan:
  make check
  ./bitcoind
Verify that `debug.log` is being written to.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D5057
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 29, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
dc3883d 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 29, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
b510876 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 29, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
291de7d 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 29, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
370eada 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 30, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
61a4464 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 2, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
00a588b 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 2, 2021
@Munkybooty
Merge bitcoin#13982: refactor: use fs:: over boost::filesystem::
b408231 
4b3b85c refactor: use fs:: over boost::filesystem:: (fanquake)

Pull request description:

  Noticed while investigating bitcoin#13973.

Tree-SHA512: 20a764d2ff460883fa0fd543c0a51031a9a202b40cfda9943f9995d3108c0a8296a3982b63bbd069167f73a1855003304a83df466763032ce7339b08b3a97d4b

# Conflicts:
#	src/qt/guiutil.cpp
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fanquake @laanwj @practicalswift @DrahtBot @maflcko