Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Windows encoding issue #13787

Merged
merged 2 commits into from Feb 12, 2019
Merged

Test for Windows encoding issue #13787

merged 2 commits into from Feb 12, 2019

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Jul 28, 2018

This PR removes unused Windows compatible path. Encoding issues has been solved.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Jul 28, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@ken2812221 ken2812221 force-pushed the test_u8path branch 5 times, most recently from ad03a5f to 8b198c8 Jul 31, 2018
@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Aug 2, 2018
@ken2812221 ken2812221 force-pushed the test_u8path branch 3 times, most recently from c14fc9c to 1166690 Jan 22, 2019
laanwj added a commit to bitcoin-core/leveldb-subtree that referenced this issue Jan 26, 2019
f8e797a Use utf-8 to decode filename (Chun Kuan Lee)

Pull request description:

  See bitcoin/bitcoin#13869

  Enable unicode support for leveldb on Windows

  CI result for applying this change is available in bitcoin/bitcoin#13787

Tree-SHA512: 860261f973ec7aec8d3051632be8154d87854df8a604ef10b9171701f132c4ba9855ca97fc6e2d529ba322a8100e1e160d5d0f2afe558158bde89979815b5246
@laanwj
Copy link
Member

@laanwj laanwj commented Feb 6, 2019

Looks like most of the prerequisites have been merged now, can we make this in before the 0.18 split?

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Feb 7, 2019

Appveyor is going to update the images in a few days. After then, we don't have to get the latest vapkg port data to get Berkeley db package and re-build vcpkg every time (3+ minutes). I will rebase it once they update the CI image.

@laanwj
Copy link
Member

@laanwj laanwj commented Feb 12, 2019

Ok, just be aware that the split is going to be 2019-03-01 and it's going to be busy around then.

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Feb 12, 2019

This is ready to review/merge. I have already rebased it.

@MarcoFalke MarcoFalke merged commit 15b3103 into bitcoin:master Feb 12, 2019
2 checks passed
MarcoFalke added a commit that referenced this issue Feb 12, 2019
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0
@ken2812221 ken2812221 deleted the test_u8path branch Feb 13, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Nov 10, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#13787 | PR13787]]

Test Plan: functional tests on windows ci

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8358
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Sep 16, 2021
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 5, 2021
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0

# Conflicts:
#	.appveyor.yml
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 5, 2021
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0

# Conflicts:
#	.appveyor.yml
Munkybooty added a commit to Munkybooty/dash that referenced this issue Oct 7, 2021
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0

# Conflicts:
#	.appveyor.yml
pravblockc added a commit to pravblockc/dash that referenced this issue Nov 18, 2021
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0

# Conflicts:
#	.appveyor.yml
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants