Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Windows encoding issue #13787

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Jul 28, 2018

This PR removes unused Windows compatible path. Encoding issues has been solved.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch 5 times, most recently Jul 30, 2018

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Aug 2, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch Oct 8, 2018

@DrahtBot DrahtBot removed the Needs rebase label Oct 8, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch Nov 5, 2018

@DrahtBot DrahtBot added Needs rebase and removed Needs rebase labels Nov 5, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch Nov 8, 2018

@DrahtBot DrahtBot removed the Needs rebase label Nov 8, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch Nov 8, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch 3 times, most recently to 1166690 Jan 22, 2019

laanwj added a commit to bitcoin-core/leveldb that referenced this pull request Jan 26, 2019

Merge #18: Use utf-8 to decode filename
f8e797a Use utf-8 to decode filename (Chun Kuan Lee)

Pull request description:

  See bitcoin/bitcoin#13869

  Enable unicode support for leveldb on Windows

  CI result for applying this change is available in bitcoin/bitcoin#13787

Tree-SHA512: 860261f973ec7aec8d3051632be8154d87854df8a604ef10b9171701f132c4ba9855ca97fc6e2d529ba322a8100e1e160d5d0f2afe558158bde89979815b5246
@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Looks like most of the prerequisites have been merged now, can we make this in before the 0.18 split?

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

Appveyor is going to update the images in a few days. After then, we don't have to get the latest vapkg port data to get Berkeley db package and re-build vcpkg every time (3+ minutes). I will rebase it once they update the CI image.

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch from 1166690 to ae892ad Feb 11, 2019

@DrahtBot DrahtBot removed the Needs rebase label Feb 11, 2019

@ken2812221 ken2812221 force-pushed the ken2812221:test_u8path branch from 4f69869 to 15b3103 Feb 11, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Ok, just be aware that the split is going to be 2019-03-01 and it's going to be busy around then.

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

This is ready to review/merge. I have already rebased it.

@MarcoFalke MarcoFalke merged commit 15b3103 into bitcoin:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Feb 12, 2019

Merge #13787: Test for Windows encoding issue
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee)
ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee)

Pull request description:

  This PR removes unused Windows compatible path. Encoding issues has been solved.

Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0

@ken2812221 ken2812221 deleted the ken2812221:test_u8path branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.