-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for Windows encoding issue #13787
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
f8e797a Use utf-8 to decode filename (Chun Kuan Lee) Pull request description: See bitcoin/bitcoin#13869 Enable unicode support for leveldb on Windows CI result for applying this change is available in bitcoin/bitcoin#13787 Tree-SHA512: 860261f973ec7aec8d3051632be8154d87854df8a604ef10b9171701f132c4ba9855ca97fc6e2d529ba322a8100e1e160d5d0f2afe558158bde89979815b5246
Looks like most of the prerequisites have been merged now, can we make this in before the 0.18 split? |
Appveyor is going to update the images in a few days. After then, we don't have to get the latest vapkg port data to get Berkeley db package and re-build vcpkg every time (3+ minutes). I will rebase it once they update the CI image. |
Ok, just be aware that the split is going to be 2019-03-01 and it's going to be busy around then. |
This is ready to review/merge. I have already rebased it. |
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0
Summary: This is a backport of Core [[bitcoin/bitcoin#13787 | PR13787]] Test Plan: functional tests on windows ci Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8358
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0 # Conflicts: # .appveyor.yml
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0 # Conflicts: # .appveyor.yml
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0 # Conflicts: # .appveyor.yml
15b3103 appveyor: Remove outdated libraries (Chun Kuan Lee) ae892ad tests: accept unicode characters on Windows (Chun Kuan Lee) Pull request description: This PR removes unused Windows compatible path. Encoding issues has been solved. Tree-SHA512: d24dce035fe3b576eaa002896f815a6691e88618ea371171d7e39883e1d63b3ed4d4631ab3b3a26bd67ae4e8ae13b1ff188942ab7ac6a93d704e0de301368cd0 # Conflicts: # .appveyor.yml
This PR removes unused Windows compatible path. Encoding issues has been solved.